From owner-freebsd-bugs@FreeBSD.ORG Fri Aug 3 11:20:08 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A3A016A420 for ; Fri, 3 Aug 2007 11:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3EB7C13C467 for ; Fri, 3 Aug 2007 11:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l73BK8O9006946 for ; Fri, 3 Aug 2007 11:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l73BK867006945; Fri, 3 Aug 2007 11:20:08 GMT (envelope-from gnats) Resent-Date: Fri, 3 Aug 2007 11:20:08 GMT Resent-Message-Id: <200708031120.l73BK867006945@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andre Albsmeier Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 014EC16A418 for ; Fri, 3 Aug 2007 11:15:09 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2]) by mx1.freebsd.org (Postfix) with ESMTP id 7D7F113C45A for ; Fri, 3 Aug 2007 11:15:08 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from mail3.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.12.6/8.12.6) with ESMTP id l73Ap1jY006336 for ; Fri, 3 Aug 2007 12:51:01 +0200 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130]) by mail3.siemens.de (8.12.6/8.12.6) with ESMTP id l73Ap1OU008594 for ; Fri, 3 Aug 2007 12:51:01 +0200 Received: (from localhost) by curry.mchp.siemens.de (8.14.1/8.14.1) id l73Ap1O0091129 for FreeBSD-gnats-submit@freebsd.org; Fri, 3 Aug 2007 12:51:01 +0200 (CEST) Message-Id: <200708031051.l73Ap0Bd064476@curry.mchp.siemens.de> Date: Fri, 3 Aug 2007 12:51:00 +0200 (CEST) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/115165: [PATCH] add functionality of mount_nfs' -L -a -d options to amd X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2007 11:20:08 -0000 >Number: 115165 >Category: bin >Synopsis: [PATCH] add functionality of mount_nfs' -L -a -d options to amd >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Aug 03 11:20:07 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Andre Albsmeier >Release: FreeBSD 6.2-STABLE i386 >Organization: >Environment: System: FreeBSD FreeBSD 6.2-STABLE #1: Wed Aug 1 15:06:22 CEST 2007 >Description: NFS can be tuned very well by using the mount_nfs options mentioned above. However, currently it is not possible to instruct amd to use these options when mounting NFS volumes. >How-To-Repeat: Try to tell amd to use the options mentioned above. >Fix: This patch adds the amd options readahead=X, dumbtimr and nolockd to amd. It also replaces the patch in PR# 85204 which only adds the readahead feature. --- contrib/amd/libamu/mount_fs.c.ORI 2006-04-12 09:02:19.000000000 +0200 +++ contrib/amd/libamu/mount_fs.c 2007-08-03 10:06:27.000000000 +0200 @@ -583,6 +583,20 @@ nap->flags |= MNT2_NFS_OPT_FSNAME; #endif /* MNT2_NFS_OPT_FSNAME */ + nap->readahead = hasmntval(mntp, "readahead"); +#ifdef MNT2_NFS_OPT_READAHEAD + if (nap->readahead) + nap->flags |= MNT2_NFS_OPT_READAHEAD; +#endif /* MNT2_NFS_OPT_READAHEAD */ + +#ifdef MNT2_NFS_OPT_DUMBTIMR + if (hasmntopt(mntp, "dumbtimr") != NULL) + nap->flags |= MNT2_NFS_OPT_DUMBTIMR; +#endif /* MNT2_NFS_OPT_DUMBTIMR */ + + if (hasmntopt(mntp, "nolockd") != NULL) + nap->flags |= NFSMNT_NOLOCKD; + nap->rsize = hasmntval(mntp, MNTTAB_OPT_RSIZE); #ifdef MNT2_NFS_OPT_RSIZE if (nap->rsize) >Release-Note: >Audit-Trail: >Unformatted: