From owner-cvs-all Wed Mar 6 15:45: 3 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 793AC37B400; Wed, 6 Mar 2002 15:44:53 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id E9CC55347; Thu, 7 Mar 2002 00:44:51 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Brian F. Feldman" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules modules.inc src/lib/libpam/modules/pam_alreadyloggedin Makefile pam_alreadyloggedin.8 pam_alreadyloggedin.c References: <200203062318.g26NIGw43435@green.bikeshed.org> From: Dag-Erling Smorgrav Date: 07 Mar 2002 00:44:51 +0100 In-Reply-To: <200203062318.g26NIGw43435@green.bikeshed.org> Message-ID: Lines: 24 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Brian F. Feldman" writes: > Robert took a look at it, and other people agreed it was a generally > interesting module to have. Add to that that it's small, not turned on > unless you do it yourself, and doesn't break the build, and I don't see what > the problem is adding a new PAM module. You know that I am working on PAM, yet it did not occur to you to even ask me if I had thought of something like this, or if I had any plans to implement something like this. Even assuming that I think pam_alreadyloggedin is a good idea (which I don't), it did not even occur to you that I might possibly object to the name of the module (which I do), or the way it was implemented (which I do), or the code style (which I do). It did not even occur to you that less than 24 hours after I completely replaced libpam with new and relatively untested code might not be the ideal time to commit a new module. I don't really mind having the module in the tree, even though I think it's a spectacularly bad idea from a security standpoint, but I do mind its name and about half of its implementation (measured in loc), so you might as well back it out. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message