From owner-cvs-src@FreeBSD.ORG  Sun Feb 29 23:07:11 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4F58A16A4CE; Sun, 29 Feb 2004 23:07:11 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 86E9543D2F; Sun, 29 Feb 2004 23:07:10 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i21779Ue010199;	Mon, 1 Mar 2004 18:07:09 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i217765c003118;	Mon, 1 Mar 2004 18:07:07 +1100
Date: Mon, 1 Mar 2004 18:07:06 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Nate Lawson <nate@root.org>
In-Reply-To: <20040229120922.R2632@root.org>
Message-ID: <20040301175645.N12828@gamplex.bde.org>
References: <20040229095536.3745A16A548@hub.freebsd.org>
	<20040229120922.R2632@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Poul-Henning Kamp <phk@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ddb db_command.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 07:07:11 -0000

On Sun, 29 Feb 2004, Nate Lawson wrote:

> On Sun, 29 Feb 2004, Poul-Henning Kamp wrote:
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/ddb              db_command.c
> >   Log:
> >   Give DDB a "watchdog" command which disables all watchdogs.
> >
> >   Revision  Changes    Path
> >   1.53      +21 -0     src/sys/ddb/db_command.c
>
> Shouldn't that be hooked into the normal debugger enter sequence?

Perhaps.  It is completely misplaced in db_command.c either way.
Subsystem-specific ddb commands go in the subsystem files.  Other
bugs in it include:
- no ifdefs to make it go away when watchdogs are not configured.
- using an event handler without including <sys/eventhandler.h
These bugs would automatically not be there if it were in watchdog.c,
and I wouldn't see them because I don't use watchdogs.

Bruce