Date: Mon, 1 Mar 2004 18:07:06 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ddb db_command.c Message-ID: <20040301175645.N12828@gamplex.bde.org> In-Reply-To: <20040229120922.R2632@root.org> References: <20040229095536.3745A16A548@hub.freebsd.org> <20040229120922.R2632@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 29 Feb 2004, Nate Lawson wrote: > On Sun, 29 Feb 2004, Poul-Henning Kamp wrote: > > FreeBSD src repository > > > > Modified files: > > sys/ddb db_command.c > > Log: > > Give DDB a "watchdog" command which disables all watchdogs. > > > > Revision Changes Path > > 1.53 +21 -0 src/sys/ddb/db_command.c > > Shouldn't that be hooked into the normal debugger enter sequence? Perhaps. It is completely misplaced in db_command.c either way. Subsystem-specific ddb commands go in the subsystem files. Other bugs in it include: - no ifdefs to make it go away when watchdogs are not configured. - using an event handler without including <sys/eventhandler.h These bugs would automatically not be there if it were in watchdog.c, and I wouldn't see them because I don't use watchdogs. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040301175645.N12828>