From owner-freebsd-current@FreeBSD.ORG  Sat Jun  4 17:31:41 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D68D316A41C
	for <current@freebsd.org>; Sat,  4 Jun 2005 17:31:41 +0000 (GMT)
	(envelope-from jake@locore.ca)
Received: from gw-kit.locore.ca (gw-kit.locore.ca [67.43.130.39])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9C51643D48
	for <current@freebsd.org>; Sat,  4 Jun 2005 17:31:39 +0000 (GMT)
	(envelope-from jake@locore.ca)
Received: from [10.0.0.3] (ws.locore.ca [10.0.0.3])
	by gw-kit.locore.ca (Postfix) with ESMTP id 9CD132BD479;
	Sat,  4 Jun 2005 13:31:38 -0400 (EDT)
Message-ID: <42A1E579.1020704@locore.ca>
Date: Sat, 04 Jun 2005 13:31:37 -0400
From: Jake Burkholder <jake@locore.ca>
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050424)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Andre Guibert de Bruet <andy@siliconlandmark.com>
References: <20050601000203.D69811@lexi.siliconlandmark.com>
In-Reply-To: <20050601000203.D69811@lexi.siliconlandmark.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: current@freebsd.org
Subject: Re: [RFC] [PATCH] VM & VFS changes
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Jun 2005 17:31:41 -0000

Andre Guibert de Bruet wrote:

> Hi,
>
> I would like to present a unified set of VM and VFS diffs for wider 
> scrutiny and testing. I have been running these diffs since May 10th 
> across daily reboots with no issues.
>
>
[...]

>Index: vm/swap_pager.c
>===================================================================
>RCS file: /home/ncvs/src/sys/vm/swap_pager.c,v
>retrieving revision 1.273
>diff -u -r1.273 swap_pager.c
>--- vm/swap_pager.c	20 May 2005 21:26:05 -0000	1.273
>+++ vm/swap_pager.c	24 May 2005 02:21:30 -0000
>@@ -2193,6 +2193,60 @@
> 	return (error);
> }
>  
>
[...]

> 
>
>+
>+		mtx_lock(&sw_dev_mtx);
>+		TAILQ_REMOVE(&swtailq, sp, sw_list);
>+
>+		sp = TAILQ_FIRST(&swtailq);
>+		free(sp, M_VMPGDATA);
>+	}
>  
>
It looks like the free should be before sp = TAILQ_FIRST() instead of after.

Jake