Date: Thu, 15 Nov 2012 11:50:27 +0100 From: Philippe =?iso-8859-1?Q?Aud=E9oud?= <jadawin@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Emanuel Haupt <ehaupt@critical.ch>, svn-ports-all@FreeBSD.org, Florian Smeets <flo@smeets.im>, ports-committers@FreeBSD.org Subject: Re: svn commit: r307446 - head/www/xpi-colorfultabs Message-ID: <20121115105027.GA19830@tuxaco.net> In-Reply-To: <20121115103854.GA66564@FreeBSD.org> References: <201211151016.qAFAGgQj064519@svn.freebsd.org> <20121115112221.ba4ce4e361a4fe5f627f0199@critical.ch> <50A4C343.7080501@smeets.im> <20121115103854.GA66564@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 15 Nov 2012, Alexey Dokuchaev wrote:
> On Thu, Nov 15, 2012 at 11:26:11AM +0100, Florian Smeets wrote:
> > On 11/15/2012 11:22, Emanuel Haupt wrote:
> > > These two files are probably not needed.
> >=20
> > Yeah, i know. I saw them but decided to just add them to the plist,
> > rather than hacking up the Makefile with something to use find on the
> > WRKSRC and delete them.
> >=20
> > If anybody sees this as a problem, i can hack the Makefile to delete
> > them prior to installation.
>=20
> Yes, it is a problem. It makes us (FreeBSD) look like careless fools not
> even able (or giving a shit about) to keep crap out of the packages we sh=
ip.
> These things add up, regardless of how non-functional they might be, to t=
he
> bad impression of us. Please try to make ports nice and clean, remove the
> crap, it's very easy:
>=20
> post-extract:
> # Remove the crap
> @${FIND} ${WRKSRC} -type f -name ... -delete
>=20
> Slighly longer for directories.
>=20
> ./danfe
Agreed with danfe and you should drop a mail to upstream maintainer to
warn him about theses useless files!
--=20
Philippe Aud=E9oud
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121115105027.GA19830>