From owner-p4-projects@FreeBSD.ORG  Wed Aug 12 23:17:39 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A16991065672; Wed, 12 Aug 2009 23:17:38 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 603F1106566B;
	Wed, 12 Aug 2009 23:17:38 +0000 (UTC) (envelope-from zec@freebsd.org)
Received: from labs3.cc.fer.hr (labs3.cc.fer.hr [161.53.72.21])
	by mx1.freebsd.org (Postfix) with ESMTP id E93178FC3D;
	Wed, 12 Aug 2009 23:17:37 +0000 (UTC)
Received: from sluga.fer.hr (sluga.cc.fer.hr [161.53.72.14])
	by labs3.cc.fer.hr (8.13.8+Sun/8.12.10) with ESMTP id n7CNHabj015023;
	Thu, 13 Aug 2009 01:17:36 +0200 (CEST)
Received: from localhost ([161.53.19.8]) by sluga.fer.hr with Microsoft
	SMTPSVC(6.0.3790.3959); Thu, 13 Aug 2009 01:17:36 +0200
From: Marko Zec <zec@freebsd.org>
To: Julian Elischer <julian@elischer.org>
Date: Thu, 13 Aug 2009 01:17:28 +0200
User-Agent: KMail/1.9.10
References: <200908122108.n7CL8uhJ058398@repoman.freebsd.org>
	<200908130058.51574.zec@freebsd.org>
	<4A834A00.1000605@elischer.org>
In-Reply-To: <4A834A00.1000605@elischer.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200908130117.28913.zec@freebsd.org>
X-OriginalArrivalTime: 12 Aug 2009 23:17:36.0834 (UTC)
	FILETIME=[1456EA20:01CA1BA3]
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Robert Watson <rwatson@freebsd.org>
Subject: Re: PERFORCE change 167260 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Aug 2009 23:17:40 -0000

On Thursday 13 August 2009 01:02:24 Julian Elischer wrote:
...
> trouble is I think we now have the init routines being called per vnet
> TWICE..

No they are not - nothing in the last commits to p4/vc2 changed anything the 
mechanisms you point out below - only pf_proto_register() has changed, and 
pf_proto_register() is not being trampolined off of any of the VNET_SYSINIT 
things, it is simply being called from the modevent handler, and it is being 
called only once.

Marko


> follow these links...
>
>
>
> vmware-current# find . -name "*.[ch]" | xargs grep vnet_domain_init
> ./kern/uipc_domain.c:vnet_domain_init(void *arg)
> ./sys/domain.h:void             vnet_domain_init(void *);
> ./sys/domain.h: VNET_SYSINIT(vnet_domain_init_ ## name,
> SI_SUB_PROTO_DOMAIN,   \
> ./sys/domain.h:     SI_ORDER_SECOND, vnet_domain_init, & name ##
> domain);      \
>
> vmware-current# find . -name "*.[ch]" | xargs grep VNET_DOMAIN_SET
> ./netinet/in_proto.c:VNET_DOMAIN_SET(inet);
> ./netgraph/ng_socket.c:VNET_DOMAIN_SET(ng);
> ./net/rtsock.c:VNET_DOMAIN_SET(route);
> ./netinet6/in6_proto.c:VNET_DOMAIN_SET(inet6);
> ./netipsec/keysock.c:VNET_DOMAIN_SET(key);
> ./sys/domain.h:#define  VNET_DOMAIN_SET(name)
>           \
> ./sys/domain.h:#define  VNET_DOMAIN_SET(name)   DOMAIN_SET(name)