From owner-svn-src-all@FreeBSD.ORG Thu Sep 10 12:48:30 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37AF7106568F; Thu, 10 Sep 2009 12:48:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 08D998FC25; Thu, 10 Sep 2009 12:48:30 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id AF47946B06; Thu, 10 Sep 2009 08:48:29 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id D45CF8A01F; Thu, 10 Sep 2009 08:48:28 -0400 (EDT) From: John Baldwin To: Dag-Erling Smorgrav Date: Thu, 10 Sep 2009 08:33:21 -0400 User-Agent: KMail/1.9.7 References: <200909100833.n8A8XSIc011874@svn.freebsd.org> In-Reply-To: <200909100833.n8A8XSIc011874@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200909100833.22353.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 10 Sep 2009 08:48:28 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197057 - in head/sys: compat/freebsd32 sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2009 12:48:30 -0000 On Thursday 10 September 2009 4:33:28 am Dag-Erling Smorgrav wrote: > Author: des > Date: Thu Sep 10 08:33:28 2009 > New Revision: 197057 > URL: http://svn.freebsd.org/changeset/base/197057 > > Log: > If a certain feature that was present in FreeBSD 7 was removed or changed in > FreeBSD 8, the compatibility shims should be built not just when FreeBSD 7 > compatibility is requested, but also when compatibility with any older > FreeBSD version where that feature was present is requested.o > > Without this patch, a kernel config that sets COMPAT_FREEBSD6 but not *7 > would fail to build due to inconsistencies between the declaration of the > compatibility shims and their use in the SysV code. > > There are similar errors in other *proto.h headers in the tree. > > MFC after: 3 weeks These are auto-generated files. Please revert. If you want to try to fix this, you will have to patch makesyscalls.sh. However, this is rather complicated. The SYSV IPC case is simpler because the system calls aren't enabled in init_sysent.c but use SYSCALL_MODULE() instead. However, other compat syscalls are enabled in init_sysent.c. One possible fix is that makesyscalls.sh could be futher extended so that compat system calls can be tagged with multiple compat versions perhaps such as 'COMPAT4|COMPAT5'. However, this would not be a trivial change to makesyscalls.sh. When this issue first came up, the consensus among other developers I talked to was that it was ok to simply mandate that 'COMPAT_FREEBSD[456]' require 'COMPAT_FREEBSD7' which has been noted in src/UPDATING. I could take a look at the makesyscalls.sh changes perhaps. -- John Baldwin