From owner-freebsd-hackers@freebsd.org Wed Dec 13 20:06:09 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DD3BE84FAD for ; Wed, 13 Dec 2017 20:06:09 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4156D808DE for ; Wed, 13 Dec 2017 20:06:08 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id PDHzeJQH7GvLHPDI0eD6LU; Wed, 13 Dec 2017 13:06:02 -0700 X-Authority-Analysis: v=2.2 cv=a9pAzQaF c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=ocR9PWop10UA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=8pX2ZrVakdhmeEh2UWIA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 25EF236A; Wed, 13 Dec 2017 12:05:59 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id vBDK5gwG003756; Wed, 13 Dec 2017 12:05:42 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id vBDK5g6G003753; Wed, 13 Dec 2017 12:05:42 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201712132005.vBDK5g6G003753@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Michael McConville cc: freebsd-hackers@freebsd.org Subject: Re: Possibly misordered arguments to memset(3) In-Reply-To: Message from Michael McConville of "Wed, 13 Dec 2017 12:02:31 -0700." <20171213190230.gf5gax7vswakgrd4@t240> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 13 Dec 2017 12:05:42 -0800 X-CMAE-Envelope: MS4wfGMAbYWuBmwqBheLC9TndcBroL91LbEOEToGEqYwgdjDWHxpwP+3x87WmYTpmMu7I7pQPh3p5INckipA7OBGWuzOJ3zD8whQ0UdLhOOI8nJt21WcRUpb bFWUll2E9HBcIElI7CUzFP1DmUKRjHuD5AzFOBUtCCELBoZdwm+ZKN/27bHcAMF3yTJZCFnklxKWX/OrmMfy3rG8ADmm09MGcXg= X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 20:06:09 -0000 In message <20171213190230.gf5gax7vswakgrd4@t240>, Michael McConville writes: > I can't claim to understand this function, but it seems unlikely that the > current ordering of the arguments was intentional. > > Thanks for your time, > Michael McConville > University of Utah > > diff --git a/tools/tools/netmap/pkt-gen.c b/tools/tools/netmap/pkt-gen.c > index 168e022cfba..6946ac3ba0e 100644 > --- a/tools/tools/netmap/pkt-gen.c > +++ b/tools/tools/netmap/pkt-gen.c > @@ -612,7 +612,7 @@ dump_payload(const char *_p, int len, struct netmap_ring > *ring, int cur) > ring->slot[cur].flags, len); > /* hexdump routine */ > for (i = 0; i < len; ) { > - memset(buf, sizeof(buf), ' '); > + memset(buf, ' ', sizeof(buf)); > sprintf(buf, "%5d: ", i); > i0 = i; > for (j=0; j < 16 && i < len; i++, j++) Good catch. Looks like it's been corrected already. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.