From owner-cvs-all@FreeBSD.ORG  Tue Dec 21 10:03:41 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 5CE7E16A4CF; Tue, 21 Dec 2004 10:03:41 +0000 (GMT)
Date: Tue, 21 Dec 2004 10:03:41 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jeremy Messenger <mezz7@cox.net>
Message-ID: <20041221100341.GA92486@FreeBSD.org>
References: <200412200709.iBK79Q2n015446@repoman.freebsd.org>
	<opsjapvver9aq2h7@mezz.mezzweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <opsjapvver9aq2h7@mezz.mezzweb.com>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@freebsd.org
cc: cvs-all@freebsd.org
cc: ports-committers@freebsd.org
Subject: Re: cvs commit: ports/x11-themes/gtk-aluminumalloy-cryogenic-theme
	pkg-plist ports/x11-themes/gtk-aluminumalloy-smog-theme
	pkg-plist ports/x11-themes/gtk-aluminumalloy-toxic-theme pkg-plist
	ports/x11-themes/gtk-aluminumalloy-volcanic-theme pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Dec 2004 10:03:41 -0000

On Mon, Dec 20, 2004 at 01:32:09AM -0600, Jeremy Messenger wrote:
> 
> Why not depend on gtk and metacity? You can't use those theme without gtk  
> and metacity. If you depend on those and you won't have that pkg-plist  
> problem. Suggest to change like this:
> 
> ==========================================
> .if ${TYPE} == "gtk"
> +USE_GNOME=gtk20
> THEME_DIR=${PREFIX}/share/themes/${THEME_NAME}
> PLIST_SUB+=GTK20=""
> PLIST_SUB+=METACITY="@comment "
> .else# metacity
> +USE_GNOME=metacity
> THEME_DIR=${PREFIX}/share/gnome/themes/${THEME_NAME}
> PLIST_SUB+=GTK20="@comment "
> PLIST_SUB+=METACITY=""
> .endif
> ==========================================

Hm..  I generally tend to not pulling in additional dependencies unless there is
an absolute need for doing so.  But I'll condsider your suggestion, thanks!

> 
> But, what if a user want to have both gtk and metacity?

There're corresponding metacity-* things exactly for that purpose.

./danfe