From owner-svn-src-all@freebsd.org Tue Aug 27 05:18:26 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0B6B7CA316; Tue, 27 Aug 2019 05:18:26 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46HcbN5Ncqz4PJP; Tue, 27 Aug 2019 05:18:24 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-oi1-x242.google.com with SMTP id b25so14016897oib.4; Mon, 26 Aug 2019 22:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1Bl6nG/cv4QU7TswMSuSRJDq7KYs5rKmg/gq+2bjjXg=; b=pZNB7QQEwJYmuBVVSt3rrhae2TocQC1whI71Hh2KZNmC+eSrgRVLQwgy3uLEDSUcam 9TuTKfdLHEq21cfgml0hD8myqKy7eAXUYmjSTa61HxkunC0QEYvF+ixlq1FjP14ojeHA I9V7wMSWSqd8P+eDOvUX1a0AEBeGmBSHZGuBwhl2zzwbuIORNM5+2WvRfGL4R2JY87Bs d5vpthAVdY9T+KnSK9+h3yS3qsSKEwt19DjAPckH1SJjSyDZfScNLlXC2Td/7lx9O6gY Bn9zESpcy6nj0V8sacwayDbziRgpyfiP1tHB3+YtPXga0+61SAXjzc5OMso1jNd6psX3 LutQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1Bl6nG/cv4QU7TswMSuSRJDq7KYs5rKmg/gq+2bjjXg=; b=mJFDPHNJQVKIluvRSC7rwNGH016u/1GQJ9ygtuP0losrltGP78Cylz+4Hd6Lr4+tYt 5RA9Z8jax9+V0JrQR1BXUI/7TStZXsR0Zp5CN+38scHwcqbkZ8R6SnEab1l94W3H9QRh nRXlzIpbQhmFqnGBY91Ge2SnNmVxhaZk+yW92v64Rvd2eOB5mc8Epbh7yk7Xkf7y6s+o iTaUPrvXeX9kGIvf/qANmljQf0obGszzpN8uU2hKvQaOEa+rR2Mbk8/Tz2jDnvO9kqeJ 59hXGvKpJTrSn56DDbpxBPW9oLBlhP3ZfRIgakEEMb0JqRBw1F4G2Nv+Gd7TWoHPPlRn uouw== X-Gm-Message-State: APjAAAWFTw3Qn46phUCaCON0hKypt5/ymZqIkSgGymTN7YalUChBFY9o fuZ6GSo7XR4h20Oqtos9X8uigvloqml5YZBuhSM= X-Google-Smtp-Source: APXvYqzaXn13uNqcYd7TDfvL7viPm+cQdpMD7bHCFM8giYohDkvftbj5LXxqqnNp+3ciWqoHH2EXjth/IqpE9FJn73k= X-Received: by 2002:aca:bb42:: with SMTP id l63mr15346725oif.85.1566883103335; Mon, 26 Aug 2019 22:18:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:2516:0:0:0:0:0 with HTTP; Mon, 26 Aug 2019 22:18:22 -0700 (PDT) In-Reply-To: <201908270417.x7R4HcfE024857@slippy.cwsent.com> References: <201908250513.x7P5DFFx017824@repo.freebsd.org> <6C6BF3A4-DC07-4D9A-9A5F-FA075BF535A8@cschubert.com> <201908261411.x7QEBMWi075354@slippy.cwsent.com> <201908270025.x7R0PtNT008594@slippy.cwsent.com> <201908270341.x7R3fJne062385@slippy.cwsent.com> <201908270417.x7R4HcfE024857@slippy.cwsent.com> From: Mateusz Guzik Date: Tue, 27 Aug 2019 07:18:22 +0200 Message-ID: Subject: Re: svn commit: r351472 - head/sys/fs/nullfs To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46HcbN5Ncqz4PJP X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=pZNB7QQE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2607:f8b0:4864:20::242 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.98 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (2.45), ipnet: 2607:f8b0::/32(-2.86), asn: 15169(-2.33), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2.4.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Aug 2019 05:18:26 -0000 This survived light testing for me: https://people.freebsd.org/~mjg/unionfs-interlock.diff note unionfs instantly panics with DEBUG_VFS_LOCKS regardless of any of this work. On 8/27/19, Cy Schubert wrote: > In message > om> > , Mateusz Guzik writes: >> On 8/27/19, Cy Schubert wrote: >> > Making progress: >> > >> > Unread portion of the kernel message buffer: >> > >> > panic: null_unlock: LK_INTERLOCK passed >> > cpuid = 2 >> > time = 1566868081 >> > KDB: stack backtrace: >> > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame >> > 0xfffffe0054a954e0 >> > vpanic() at vpanic+0x19d/frame 0xfffffe0054a95530 >> > panic() at panic+0x43/frame 0xfffffe0054a95590 >> > null_unlock() at null_unlock+0x8a/frame 0xfffffe0054a955d0 >> > VOP_UNLOCK_APV() at VOP_UNLOCK_APV+0x56/frame 0xfffffe0054a955f0 >> > unionfs_unlock() at unionfs_unlock+0x124/frame 0xfffffe0054a95650 >> > VOP_UNLOCK_APV() at VOP_UNLOCK_APV+0x56/frame 0xfffffe0054a95670 >> > vfs_domount() at vfs_domount+0xc3f/frame 0xfffffe0054a958a0 >> > vfs_donmount() at vfs_donmount+0x934/frame 0xfffffe0054a95940 >> > sys_nmount() at sys_nmount+0x69/frame 0xfffffe0054a95980 >> > amd64_syscall() at amd64_syscall+0x3ae/frame 0xfffffe0054a95ab0 >> > fast_syscall_common() at fast_syscall_common+0x101/frame >> > 0xfffffe0054a95ab0 >> > --- syscall (378, FreeBSD ELF64, sys_nmount), rip = 0x2bed6a4a, rsp = >> > 0x7fffffffe2e8, rbp = 0x7fffffffec70 --- >> > Uptime: 1m35s >> > >> >> Ok, this explains everything. I did not think anyone uses unionfs, >> let alone stacked on top of nullfs. I'll have a patch later. > > It's for a few jails. Thanks for persevering. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > > > -- Mateusz Guzik