From owner-freebsd-fs@FreeBSD.ORG Tue Oct 11 10:09:23 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F784106566C for ; Tue, 11 Oct 2011 10:09:23 +0000 (UTC) (envelope-from se@freebsd.org) Received: from nm13.bullet.mail.ne1.yahoo.com (nm13.bullet.mail.ne1.yahoo.com [98.138.90.76]) by mx1.freebsd.org (Postfix) with SMTP id 0569D8FC17 for ; Tue, 11 Oct 2011 10:09:22 +0000 (UTC) Received: from [98.138.90.52] by nm13.bullet.mail.ne1.yahoo.com with NNFMP; 11 Oct 2011 09:56:35 -0000 Received: from [98.138.226.62] by tm5.bullet.mail.ne1.yahoo.com with NNFMP; 11 Oct 2011 09:56:35 -0000 Received: from [127.0.0.1] by smtp213.mail.ne1.yahoo.com with NNFMP; 11 Oct 2011 09:56:35 -0000 X-Yahoo-Newman-Id: 203430.45212.bm@smtp213.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 7kTvs0sVM1mZk3Ha8DovQ_LqDzX939vFQMKtc1kjYKeWm34 42WoSbu1KXqU_ZwA0oh5PKchW1gLM4jccrq13DMnkqriLCUyAWXgGgXRZaoa HAcppjWBX9goM4surFPM_whs6niOGDlml.nmc.1AGPRnYZQW.Gk9HHTFKehz tmRgdBWfcrSlcH_0cBO_O22Kp_vUK.NNeRDxkqbzbuHaoS101JPeoAVeaSr5 PvIKhAMDz5mnO5EFlp7dKYdSymoWX35Lc0gqjfCPjpItOzB2UKzfaR2cj87z W.rIUJSX5gm64kgXBoQvMgipLUK05LJvMuZvLJp2W_WqotSgEevLd_67w8R6 rYIIhsVRCklOjtDlqS54i79UWVQX17CUsveL1jgASEhy7OppBVT2YNovNHuq U3ncstI2.avydRCE- X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. Received: from [192.168.119.20] (se@81.173.155.124 with plain) by smtp213.mail.ne1.yahoo.com with SMTP; 11 Oct 2011 02:56:34 -0700 PDT Message-ID: <4E9412D3.4020705@freebsd.org> Date: Tue, 11 Oct 2011 11:56:35 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: mm@FreeBSD.org References: <201110110726.p9B7QhEC072913@freefall.freebsd.org> In-Reply-To: <201110110726.p9B7QhEC072913@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org, sm@kill-9.net Subject: Re: bin/121366: [zfs] [patch] Automatic disk scrubbing from periodic(8) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 10:09:23 -0000 On 11.10.2011 09:26, mm@FreeBSD.org wrote: > Synopsis: [zfs] [patch] Automatic disk scrubbing from periodic(8) > > State-Changed-From-To: open->closed > State-Changed-By: mm > State-Changed-When: Tue Oct 11 07:26:43 UTC 2011 > State-Changed-Why: > Implemented in r209195 by netchild@ (/etc/periodic/daily/800.scrub-zfs) > > http://www.freebsd.org/cgi/query-pr.cgi?pr=121366 There is no mention of daily_scrub_zfs_enable daily_scrub_zfs_pools daily_scrub_zfs_default_threshold daily_scrub_zfs_${poolname}_threshold in /etc/defaults/periodic.conf, which we use to define configuration options for all periodic scripts. The attached patch adds the missing entries. I'm not sure about the commented out line for "daily_scrub_zfs_${poolname}_threshold", but there is precedent (in the "amd" section) and I think many users will grep for scrub_zfs in that file instead of looking into the man-page for periodic.conf. If the defaults in the patch are considered OK (they just state the defaults set in the script), I'd like to commit them to head and MFC within a week. Regards, STefan (Please include my address in replies, since I'm not in freebsd-fs@). PS: The following unrelated variables have no defaults defined: daily_backup_distfile_enable daily_backup_pkgdb_dbdir daily_distfile_enable I have not yet looked up their defaults, but I think they should also be defined in defaults/periodic.conf ...