From owner-svn-src-head@freebsd.org Wed Sep 25 21:13:06 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5243F13347A; Wed, 25 Sep 2019 21:13:06 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46drPZ1RlBz4Yxv; Wed, 25 Sep 2019 21:13:06 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id F3D0FD5DF; Wed, 25 Sep 2019 21:13:05 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::fdb1:1a26:679b:6133] (unknown [IPv6:2001:470:7a58:0:fdb1:1a26:679b:6133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E5D275EE59; Wed, 25 Sep 2019 23:13:03 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_B7BDB3A6-35C6-49F6-90B5-165671961A09"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r352661 - head/sys/netinet/tcp_stacks Date: Wed, 25 Sep 2019 23:12:55 +0200 In-Reply-To: Cc: Bruce Evans , src-committers , svn-src-all , svn-src-head To: Ed Maste References: <201909242036.x8OKahnv021758@repo.freebsd.org> <20190925070207.Y3271@besplex.bde.org> X-Mailer: Apple Mail (2.3445.104.11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2019 21:13:06 -0000 --Apple-Mail=_B7BDB3A6-35C6-49F6-90B5-165671961A09 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 25 Sep 2019, at 15:36, Ed Maste wrote: >=20 > On Tue, 24 Sep 2019 at 17:39, Bruce Evans = wrote: >>=20 >> On i386, these types have different sizes, so >> gcc detects the type mismatch. clang is too broken to report this = type >> mismatch. >=20 > Interesting, it seems Clang doesn't even warn in the case of casting a > uint64_t to a 32-bit pointer. Looks like there are some useful > warnings that ought to be implemented. There is -Wconversion for this, or the more specific -Wshorten-64-to-32: $ cat shorten.c int foo(long l) { return l; } $ clang -Wconversion -c shorten.c shorten.c:3:10: warning: implicit conversion loses integer precision: = 'long' to 'int' [-Wshorten-64-to-32] return l; ~~~~~~ ^ 1 warning generated. But for some reason this warning isn't enabled by default, even with = -Wall. I guess you would get a zillion warnings on our tree, if you enabled = this. :) -Dimitry --Apple-Mail=_B7BDB3A6-35C6-49F6-90B5-165671961A09 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXYvYVwAKCRCwXqMKLiCW o4otAKDfngl9Y+ZW0gOHPShvGyEvjJ8bMACeIOyQoNfj431asRs+JO7tD2LTrKU= =EjjJ -----END PGP SIGNATURE----- --Apple-Mail=_B7BDB3A6-35C6-49F6-90B5-165671961A09--