From owner-freebsd-hackers@FreeBSD.ORG  Mon Oct  7 20:46:48 2013
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 4CE421D1
 for <hackers@freebsd.org>; Mon,  7 Oct 2013 20:46:48 +0000 (UTC)
 (envelope-from phk@phk.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id 1389721F4
 for <hackers@freebsd.org>; Mon,  7 Oct 2013 20:46:47 +0000 (UTC)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3])
 by phk.freebsd.dk (Postfix) with ESMTP id 456303EA02;
 Mon,  7 Oct 2013 20:46:46 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.14.7/8.14.7) with ESMTP id r97KkjHe000816;
 Mon, 7 Oct 2013 20:46:46 GMT (envelope-from phk@phk.freebsd.dk)
To: Eitan Adler <lists@eitanadler.com>
Subject: Re: patch(1) depends on RCS - should it?
In-reply-to: <CAF6rxgni6kw6qtLMwWQdc2SuQp+Wa5-pTQwgSbTPa1-x_vznEA@mail.gmail.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <CAF6rxgni6kw6qtLMwWQdc2SuQp+Wa5-pTQwgSbTPa1-x_vznEA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Date: Mon, 07 Oct 2013 20:46:45 +0000
Message-ID: <815.1381178805@critter.freebsd.dk>
X-Mailman-Approved-At: Mon, 07 Oct 2013 21:02:49 +0000
Cc: hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Oct 2013 20:46:48 -0000

In message <CAF6rxgni6kw6qtLMwWQdc2SuQp+Wa5-pTQwgSbTPa1-x_vznEA@mail.gmail.com>
, Eitan Adler writes:

>patch(1) explicitly tries to use RCS (and SCCS) in certain cases.  Are
>we okay with a base system utility that behaves differently depending
>on whether a port is installed? Should the relevant code be removed
>from patch(1)?
>
>See head/usr.bin/patch/inp.c lines 166 to 240 for details.

Yes, that code should be removed.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.