From owner-svn-src-all@FreeBSD.ORG  Tue Sep 23 18:44:40 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5FB7E10E;
 Tue, 23 Sep 2014 18:44:40 +0000 (UTC)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C538F859;
 Tue, 23 Sep 2014 18:44:39 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s8NIiY9U012346
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 23 Sep 2014 21:44:34 +0300 (EEST)
 (envelope-from kostik@tom.home)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua s8NIiY9U012346
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id s8NIiYnd012345;
 Tue, 23 Sep 2014 21:44:34 +0300 (EEST) (envelope-from kostik)
Date: Tue, 23 Sep 2014 21:44:34 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r272032 - head/sys/conf
Message-ID: <20140923184434.GG8870@kib.kiev.ua>
References: <201409231704.s8NH4Lcv098184@svn.freebsd.org>
 <20140923182051.GF8870@kib.kiev.ua> <5421BC8E.6000709@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5421BC8E.6000709@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
 HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Sep 2014 18:44:40 -0000

On Tue, Sep 23, 2014 at 01:31:42PM -0500, Bryan Drewery wrote:
> On 9/23/2014 1:20 PM, Konstantin Belousov wrote:
> > On Tue, Sep 23, 2014 at 05:04:21PM +0000, Bryan Drewery wrote:
> >> Author: bdrewery
> >> Date: Tue Sep 23 17:04:21 2014
> >> New Revision: 272032
> >> URL: http://svnweb.freebsd.org/changeset/base/272032
> >>
> >> Log:
> >>   DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it.
> >>   fstat(1) now uses libprocstat(9).  There is no userland impact to using this.
> > 
> > DEBUG_VFS_LOCKS does modify KBI of VFS, by adding struct stack to
> > lockmgr, and lockmgr is embedded into each struct vnode.
> > 
> > VFS modules, in particular, filesystems, compiled for mismatched
> > kernel WRT DEBUG_VFS_LOCKS, would cause strange breakage.
> 
> Well, perhaps the comment needs to be updated to state that
> DEBUG_VFS_LOCKS modifies VFS KBI so any VFS modules will need to recompiled.
> 
> I did see the stack was moved to lockmgr, but given the use of
> libprocstat, and lockmgr being a kernel struct, I don't think it's worth
> mentioning userland here.
> 
> Sound good?
I agree, I do not think that userland is affected.