From owner-freebsd-ports@FreeBSD.ORG  Sat Dec  9 17:27:13 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@FreeBSD.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2789F16A403;
	Sat,  9 Dec 2006 17:27:13 +0000 (UTC)
	(envelope-from nork@FreeBSD.org)
Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 76E7043C9E;
	Sat,  9 Dec 2006 17:26:05 +0000 (GMT)
	(envelope-from nork@FreeBSD.org)
Received: from nadesico.ninth-nine.com (nadesico.ninth-nine.com
	[219.127.74.122]) by sakura.ninth-nine.com
	(8.13.8/8.13.8/NinthNine) with SMTP id kB9HR8aq037997;
	Sun, 10 Dec 2006 02:27:09 +0900 (JST) (envelope-from nork@FreeBSD.org)
Date: Sun, 10 Dec 2006 02:27:08 +0900
From: Norikatsu Shigemura <nork@FreeBSD.org>
To: Antoine Brodin <antoine.brodin@laposte.net>
Message-Id: <20061210022708.dfe9b414.nork@FreeBSD.org>
In-Reply-To: <20061209162636.f0317a36.antoine.brodin@laposte.net>
References: <20061209231907.66900b70.nork@FreeBSD.org>
	<20061209162636.f0317a36.antoine.brodin@laposte.net>
X-Mailer: Sylpheed version 2.3.0beta5 (GTK+ 2.10.6; i386-portbld-freebsd6.2)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2
	(sakura.ninth-nine.com [219.127.74.121]);
	Sun, 10 Dec 2006 02:27:09 +0900 (JST)
Cc: ports@FreeBSD.org, Norikatsu Shigemura <nork@FreeBSD.org>
Subject: Re: [ports/devel/libgii] Respect PTHREAD_LIBS
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Dec 2006 17:27:13 -0000

On Sat, 9 Dec 2006 16:26:36 +0100
Antoine Brodin <antoine.brodin@laposte.net> wrote:
> > 	I found a issue of not respect PTHREAD_LIBS.
> > 	May I commit following patch?
> [snip]
> Approved.  Is there something to submit upstream ?
> Can you replace INSTALLS_SHLIB=yes by USE_LDCONFIG=yes, while you are at it ?

	Thank you.  I committed, done.

	Yes, if passible, please submit 'check PTHREAD_LIBS and PTHREAD_CFLAGS
	in configure like synergy's configure.'.  I confirmed following
	codes in synergy(synergy-1.3.1.tar.gz)'s aclocal.m4.
	Please SEE ALSO: http://synergy2.sourceforge.net/


# First of all, check if the user has set any of the PTHREAD_LIBS,
# etcetera environment variables, and if threads linking works using
# them:
if test x"$PTHREAD_LIBS$PTHREAD_CFLAGS" != x; then
        save_CFLAGS="$CFLAGS"
        CFLAGS="$CFLAGS $PTHREAD_CFLAGS"
        save_LIBS="$LIBS"
        LIBS="$PTHREAD_LIBS $LIBS"
        AC_MSG_CHECKING([for pthread_join in LIBS=$PTHREAD_LIBS with CFLAGS=$PTH
READ_CFLAGS])
        AC_TRY_LINK_FUNC(pthread_join, acx_pthread_ok=yes)
        AC_MSG_RESULT($acx_pthread_ok)
        if test x"$acx_pthread_ok" = xno; then
                PTHREAD_LIBS=""
                PTHREAD_CFLAGS=""
        fi
        LIBS="$save_LIBS"
        CFLAGS="$save_CFLAGS"
fi