From nobody Mon Apr 20 17:20:23 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fzsgq2zT6z6ZCmJ for ; Mon, 20 Apr 2026 17:20:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fzsgq2Pzkz3VXK for ; Mon, 20 Apr 2026 17:20:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776705623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AZn6rRrANkLkLu+7ON1PWeeHI6NQvnOufxbB2xtSqr4=; b=KEEXyILE/jTKw2UYS+INiOeZYGScvDuasMU6iwoW0jNJlVCpkE4fgS8m659ZJ+FjPSiFBh iFaGn73KdRK2/9KIjoM54vVH2zmbT3TEvvy23Atw0n+8eCDlWEsuHclDhAkWntz1Mc3DoU EhjRwIxuJNbo3oe9DphMMu6u20SnfDijj+mwwBeuJeQNeb66pZVu4xQgDmjhQTp1Lxf5xy jooYUNngkqX0lgovM8QFZxa9RhLgmeC25FkHIS0Hb0MXNROIIrOM9V6UA/5K1kNZTX7TSz DThyzBMC4ynEMweutMrGB///xHBed8fSibNkRV9FWY4UYT1dnLubCHhIJB2AVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776705623; a=rsa-sha256; cv=none; b=D8NfUgok5E6thNRYhzC8V8iPw9RObkJC2xxdC4iIv6uG0OWxX68dPRqNSWZB0jueI9K9mZ +a8jX2HipitoRtCXuhDaYYfAtEi2sFgdpm6sv629HxNxd46BAYlDpimi4aENUV3MCdfslv gnyU4QoDbxD1rIRcAxVCH3yFK0ztSRGntKBVlvb0tYTvUPSZkv680f/QAqbSoLf2Lon2N5 m37Xe3h8F0Vmf8f/4GROf3K1KKi2oDdgNwwmo36SRU35Aovh1g7mJFTJxBAI9ZJdO0eL/6 mpUxkdRrei87spARFYJSQ7y+JdvQLV/DEP4jL3ClQ6vNwkmAFTCoMBs5Agyd6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776705623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AZn6rRrANkLkLu+7ON1PWeeHI6NQvnOufxbB2xtSqr4=; b=XGPHssLPK9Lld0X/+r9pOEgiqYbWnWOS95nIAcZwxnNXGSVdE69qvveIT+dl5frJ2M4kH/ Vua1tBKErKrerzt4YkuUN9T/7uZ5MSdDjNndLi7OweqTfYk74wNaUMPIHvImrBssaVX2Xm OjB/3pk8UP/GydeBsennu48XVTZFcc63a5Sh4HE1VJ+HBk9c/X9ezB91Jvl3dkxDuM9tWg ttuzU+L7LXywPtaYkcY2TmhHxzsJQHWsLsOt4GLgjxcME3+24q2E8v27HCI0YxM8Cx8a72 nnedavGex6ZisYtesmRLsqdvHtCvwONHb61mpAQXe3Eqe6yDRJO+Kx6B5PUgxA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fzsgq1cc1z15bj for ; Mon, 20 Apr 2026 17:20:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f615 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 20 Apr 2026 17:20:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 505f381cb96e - main - nvmf_che: Don't leak a socket if an error occurs finalizing the socket List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 505f381cb96ee25bcf0df11cfaf15a601d969500 Auto-Submitted: auto-generated Date: Mon, 20 Apr 2026 17:20:23 +0000 Message-Id: <69e66057.3f615.57d6933e@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=505f381cb96ee25bcf0df11cfaf15a601d969500 commit 505f381cb96ee25bcf0df11cfaf15a601d969500 Author: John Baldwin AuthorDate: 2026-04-20 17:18:04 +0000 Commit: John Baldwin CommitDate: 2026-04-20 17:18:04 +0000 nvmf_che: Don't leak a socket if an error occurs finalizing the socket If soreserve() or sosetopt() (to set TCP_NODELAY) fails after claiming the socket from the file descriptor, explicitly close the socket before returning failure. Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D55493 --- sys/dev/cxgbe/nvmf/nvmf_che.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/cxgbe/nvmf/nvmf_che.c b/sys/dev/cxgbe/nvmf/nvmf_che.c index afdfc2f1b758..be54e7bebfea 100644 --- a/sys/dev/cxgbe/nvmf/nvmf_che.c +++ b/sys/dev/cxgbe/nvmf/nvmf_che.c @@ -2605,6 +2605,7 @@ che_allocate_qpair(bool controller, const nvlist_t *nvl) free(qp->fl_cids, M_NVMF_CHE); free(qp->open_fl_ttags, M_NVMF_CHE); free(qp, M_NVMF_CHE); + soclose(so); return (NULL); }