From owner-freebsd-audit Mon Jul 23 9:40:28 2001 Delivered-To: freebsd-audit@freebsd.org Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by hub.freebsd.org (Postfix) with ESMTP id C2C7037B40D for ; Mon, 23 Jul 2001 09:40:21 -0700 (PDT) (envelope-from sheldonh@starjuice.net) Received: from sheldonh (helo=axl.seasidesoftware.co.za) by axl.seasidesoftware.co.za with local-esmtp (Exim 3.31 #1) id 15OilZ-0000zN-00; Mon, 23 Jul 2001 18:41:09 +0200 From: Sheldon Hearn To: David Hill Cc: audit@freebsd.org Subject: Re: STD*_FILENO patches #2 In-reply-to: Your message of "Mon, 23 Jul 2001 12:25:35 -0400." <20010723122535.3cbd53ef.david@phobia.ms> Date: Mon, 23 Jul 2001 18:41:08 +0200 Message-ID: <3804.995906468@axl.seasidesoftware.co.za> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 23 Jul 2001 12:25:35 -0400, David Hill wrote: > NOTE: > pcvt - > header.h patch now contains #include Wrong approach. Private (or local, or build-only) headers shouldn't be used to include all the crap that the source files that include them require. They should only include headers that are required for the things that they themselves declare and define. As an example/ pcvt's header.h includes so that the type "struct sgttyb" is available for the delcaration of sgttyOrg and sgttyNew. You should include from the file that needs it; in this case, it's main.c . > window > #include is in ww.h patch Probably the same problem here. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message