From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 19 18:10:12 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF66F1065672 for ; Wed, 19 Jan 2011 18:10:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 92D808FC08 for ; Wed, 19 Jan 2011 18:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0JIACxG058742 for ; Wed, 19 Jan 2011 18:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0JIACUh058741; Wed, 19 Jan 2011 18:10:12 GMT (envelope-from gnats) Resent-Date: Wed, 19 Jan 2011 18:10:12 GMT Resent-Message-Id: <201101191810.p0JIACUh058741@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Petr Lampa Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AF841065673 for ; Wed, 19 Jan 2011 18:04:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 405FE8FC12 for ; Wed, 19 Jan 2011 18:04:35 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0JI4YCt012438 for ; Wed, 19 Jan 2011 18:04:34 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p0JI4Y0K012437; Wed, 19 Jan 2011 18:04:34 GMT (envelope-from nobody) Message-Id: <201101191804.p0JI4Y0K012437@red.freebsd.org> Date: Wed, 19 Jan 2011 18:04:34 GMT From: Petr Lampa To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/154147: netstat -ian leaking out embedded scope index X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2011 18:10:13 -0000 >Number: 154147 >Category: bin >Synopsis: netstat -ian leaking out embedded scope index >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 19 18:10:12 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Petr Lampa >Release: 8.2-PRERELEASE >Organization: BUT FIT >Environment: FreeBSD XXX 8.2-PRERELEASE FreeBSD 8.2-PRERELEASE #18: Tue Jan 18 15:59:42 CET 2011 XXX@XXX:/usr/src/sys/i386/compile/GUTA i386 >Description: netstat -ian em0 1500 2001:718:802: 2001:718:802:809: 22110 - - 25384 - - ff05::1:3 (refs: 1) ff02:1::1:2 (refs: 1) ff02:1::202 (refs: 1) ff02:1::1:ffe5:913 (refs: 1) ff02:1::1:ffe5:90b (refs: 1) ff01:1::1 (refs: 1) ff02:1::2:7d68:cd71(refs: 1) ff02:1::1 (refs: 1) ff02:1::1:ff30:8646(refs: 1) Some multicast addresses have embedded scope index in output. Original report is here: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=280697+0+current/freebsd-net >How-To-Repeat: netstat -ian >Fix: /usr/src/usr.bin/netstat *** if.c.old 2011-01-19 18:41:32.000000000 +0100 --- if.c 2011-01-19 18:53:18.000000000 +0100 *************** *** 475,480 **** --- 475,487 ---- break; #ifdef INET6 case AF_INET6: + if (IN6_IS_ADDR_LINKLOCAL(&msa.in6.sin6_addr) || + IN6_IS_ADDR_MC_NODELOCAL(&msa.in6.sin6_addr) || + IN6_IS_ADDR_MC_LINKLOCAL(&msa.in6.sin6_addr)) { + + msa.in6.sin6_addr.s6_addr[2] = 0; + msa.in6.sin6_addr.s6_addr[3] = 0; + } printf("%*s %-19.19s(refs: %d)\n", Wflag ? 27 : 25, "", inet_ntop(AF_INET6, Patch attached with submission follows: *** usr.bin/netstat/if.c.old 2011-01-19 18:41:32.000000000 +0100 --- usr.bin/netstat/if.c 2011-01-19 18:53:18.000000000 +0100 *************** *** 475,480 **** --- 475,487 ---- break; #ifdef INET6 case AF_INET6: + if (IN6_IS_ADDR_LINKLOCAL(&msa.in6.sin6_addr) || + IN6_IS_ADDR_MC_NODELOCAL(&msa.in6.sin6_addr) || + IN6_IS_ADDR_MC_LINKLOCAL(&msa.in6.sin6_addr)) { + + msa.in6.sin6_addr.s6_addr[2] = 0; + msa.in6.sin6_addr.s6_addr[3] = 0; + } printf("%*s %-19.19s(refs: %d)\n", Wflag ? 27 : 25, "", inet_ntop(AF_INET6, >Release-Note: >Audit-Trail: >Unformatted: