From owner-cvs-src@FreeBSD.ORG  Sat Jul 29 20:39:00 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4634416A4E0;
	Sat, 29 Jul 2006 20:39:00 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep11-int.chello.at (viefep13-int.chello.at [213.46.255.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5526943D55;
	Sat, 29 Jul 2006 20:38:53 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep11-int.chello.at
	(InterMail vM.6.01.05.04 201-2131-123-105-20051025) with ESMTP id
	<20060729203852.MGIX4985.viefep11-int.chello.at@wombat.fafoe.narf.at>;
	Sat, 29 Jul 2006 22:38:52 +0200
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 8A649BC75; Sat, 29 Jul 2006 22:38:51 +0200 (CEST)
Date: Sat, 29 Jul 2006 22:38:50 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: "Simon L. Nielsen" <simon@FreeBSD.org>
Message-ID: <20060729203850.GA79580@wombat.fafoe.narf.at>
References: <200607282300.k6SN0Gdn005489@repoman.freebsd.org>
	<20060729061426.GA79029@wombat.fafoe.narf.at>
	<20060729110923.GA1085@zaphod.nitro.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060729110923.GA1085@zaphod.nitro.dk>
User-Agent: Mutt/1.5.12-2006-07-14
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libmp mpasbn.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Jul 2006 20:39:00 -0000

On Sat, Jul 29, 2006 at 01:09:24PM +0200, Simon L. Nielsen wrote:
> On 2006.07.29 08:14:27 +0200, Stefan Farfeleder wrote:
> > On Fri, Jul 28, 2006 at 11:00:16PM +0000, Simon L. Nielsen wrote:
> > > simon       2006-07-28 23:00:16 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     lib/libmp            mpasbn.c 
> > >   Log:
> > >   Do not put BN_CTX structures on the stack, but instead allocate them
> > >   runtime using BN_CTX_new().  This is done since in OpenSSL 0.9.7e we
> > >   can only allocate BN_CTX on the stack by including an internal OpenSSL
> > >   header file, and in OpenSSL 0.9.8 BN_CTX is entirely opaque, so having
> > >   it on the stack is not possible at all.
> > >   
> > >   This is done as preparation for OpenSSL 0.9.8b import.
> > 
> > It might be preferable to pass the allocated BN_CTXs to _mdiv(),
> > _mult() and _sdiv() because then msqrt() would have to call
> > BN_CTX_new() only once.
> 
> Sounds like a good idea.  How about the attached patch?

Thanks, looks good.