From owner-svn-src-projects@FreeBSD.ORG  Fri Nov 14 18:21:02 2014
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6EB6FEFA;
 Fri, 14 Nov 2014 18:21:02 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id E848AC80;
 Fri, 14 Nov 2014 18:21:00 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sAEIKvx9012435
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 14 Nov 2014 21:20:57 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sAEIKvgm012434;
 Fri, 14 Nov 2014 21:20:57 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 14 Nov 2014 21:20:57 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r274517 - projects/sendfile/sys/vm
Message-ID: <20141114182057.GD1031@FreeBSD.org>
References: <201411141801.sAEI1IWo066725@svn.freebsd.org>
 <F29804BE-DBDD-45D7-AC71-D1B9482C4415@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F29804BE-DBDD-45D7-AC71-D1B9482C4415@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2014 18:21:02 -0000

On Fri, Nov 14, 2014 at 10:17:35AM -0800, Garrett Cooper wrote:
G> > Log:
G> >  Use C99 "inline" keyword.
G> > 
G> > Modified:
G> >  projects/sendfile/sys/vm/vm_pager.h
G> > 
G> > Modified: projects/sendfile/sys/vm/vm_pager.h
G> > ==============================================================================
G> > --- projects/sendfile/sys/vm/vm_pager.h	Fri Nov 14 18:00:00 2014	(r274516)
G> > +++ projects/sendfile/sys/vm/vm_pager.h	Fri Nov 14 18:01:18 2014	(r274517)
G> > @@ -106,7 +106,7 @@ vm_object_t vm_pager_allocate(objtype_t,
G> > void vm_pager_bufferinit(void);
G> > void vm_pager_deallocate(vm_object_t);
G> > static __inline int vm_pager_get_pages(vm_object_t, vm_page_t *, int, int);
G> > -static __inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, int,
G> > +static inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, int,
G> >     int, void(*)(void *, int), void *);
G> > static __inline boolean_t vm_pager_has_page(vm_object_t, vm_pindex_t, int *, int *);
G> > void vm_pager_init(void);
G> > @@ -138,7 +138,7 @@ vm_pager_get_pages(
G> > 	return (r);
G> > }
G> 
G> - What was wrong with using the "non-C99" constant?

It was compiler keyword from XX century.

G> - Why not the other cases above that, e.g. vm_pager_get_pages?

Alan asks to avoid any style(9) changes to sys/vm, so that svn annotate
works. However, new code should be styled properly.

-- 
Totus tuus, Glebius.