From owner-cvs-src@FreeBSD.ORG Mon Jul 23 20:55:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A69B416A420 for ; Mon, 23 Jul 2007 20:55:24 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id 555C613C481 for ; Mon, 23 Jul 2007 20:55:24 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 23021 invoked by uid 399); 23 Jul 2007 20:55:23 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 23 Jul 2007 20:55:23 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <46A515B9.6060608@FreeBSD.org> Date: Mon, 23 Jul 2007 13:55:21 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.5 (X11/20070723) MIME-Version: 1.0 To: Marcus Alves Grando References: <200707231452.l6NEqMot074554@repoman.freebsd.org> <46A4F893.20609@FreeBSD.org> In-Reply-To: <46A4F893.20609@FreeBSD.org> X-Enigmail-Version: 0.95.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Attilio Rao , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_kse.c kern_thread.c src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2007 20:55:24 -0000 Marcus Alves Grando wrote: > Attilio Rao wrote: >> attilio 2007-07-23 14:52:22 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_kse.c kern_thread.c >> sys/sys proc.h Log: >> Actually, KSE kernel bits locking is broken and can lead likely to >> dangerous races. >> Fix this problems adding correct locking for the members of 'struct >> kse_upcall' and other struct proc/struct thread related members. >> For the moment, just leave ku_mflag and ku_flags "lazy" locked. >> While here, cleanup the code removing the function kse_GC() (unused), >> and merging upcall_link(), upcall_unlink(), upcall_stash() in their >> respective callers (static functions, very short and only called in one >> place). >> Reported by: pav >> Tested by: pav (on some pointyhat cluster nodes) >> Approved by: jeff >> Approved by: re >> Sponsorized by: NGX Italy (http://www.ngx.it) >> Revision Changes Path >> 1.232 +69 -82 src/sys/kern/kern_kse.c >> 1.251 +2 -0 src/sys/kern/kern_thread.c >> 1.488 +0 -1 src/sys/sys/proc.h >> _______________________________________________ >> cvs-src@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/cvs-src >> To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" >> >> ------------------------------------------------------ >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/kern/kern_kse.c.diff?&r1=1.231&r2=1.232 >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/kern/kern_thread.c.diff?&r1=1.250&r2=1.251 >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/sys/proc.h.diff?&r1=1.487&r2=1.488 >> >> > > Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys > -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS > -include opt_global.h -fno-common -finline-limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 > -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx > -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror > /usr/src/sys/kern/kern_kse.c > cc1: warnings being treated as errors > /usr/src/sys/kern/kern_kse.c:87: warning: 'upcall_free' defined but not > used > *** Error code 1 Me Too. Removing the prototype and the function definition got the kernel to compile, but I'm a little scared to boot it. :) hth, Doug -- This .signature sanitized for your protection