From owner-cvs-src@FreeBSD.ORG  Mon Jul  9 20:59:15 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0620316A46C;
	Mon,  9 Jul 2007 20:59:15 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id B065C13C46C;
	Mon,  9 Jul 2007 20:59:14 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l69KvrxT003061;
	Mon, 9 Jul 2007 14:57:53 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 09 Jul 2007 14:58:34 -0600 (MDT)
Message-Id: <20070709.145834.689651504.imp@bsdimp.com>
To: mureninc@gmail.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <f34ca13c0707091246m334899b7u81255d15767bbdea@mail.gmail.com>
References: <200707091658.l69Gw8MG080618@repoman.freebsd.org>
	<f34ca13c0707091246m334899b7u81255d15767bbdea@mail.gmail.com>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Mon, 09 Jul 2007 14:57:54 -0600 (MDT)
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/usb if_rue.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2007 20:59:15 -0000

In message: <f34ca13c0707091246m334899b7u81255d15767bbdea@mail.gmail.com>
            "Constantine A. Murenin" <mureninc@gmail.com> writes:
: On 09/07/07, Warner Losh <imp@freebsd.org> wrote:
: > imp         2007-07-09 16:58:08 UTC
: >
: >   FreeBSD src repository
: >
: >   Modified files:
: >     sys/dev/usb          if_rue.c
: >   Log:
: >   When all the other drivers were converted to scheduling a taskqueue to
: >   do the heavy lifting of the 'mii_tick' function, rue was left behind.
: >   Implement this in a naive way.  Reports from the field show this makes
: >   the driver functional with some locking issues, as opposed to an
: >   instant panic.  Those will be addressed in a later version of the
: >   driver.
: >
: >   Approved by: re@ (bmah)
: >
: >   Revision  Changes    Path
: >   1.40      +18 -0     src/sys/dev/usb/if_rue.c
: 
: I think you forgot to commit a change to src/sys/dev/usb/if_ruereg.h:
: 
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand
: operand of comma expression has no effect
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: error: 'struct
: rue_softc' has no member named 'rue_tick_task'
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand
: operand of comma expression has no effect
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_detach':
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:710: error: 'struct
: rue_softc' has no member named 'rue_tick_task'
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_tick':
: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:931: error: 'struct
: rue_softc' has no member named 'rue_tick_task'

Pointy hat to me.  I sent the full patch to re@ for approval, but
neglected the if_ruereg.h part when I committed it. :-(.  Bad Imp.  No
biscuit.

Warner