From owner-freebsd-net@FreeBSD.ORG  Sun Dec  6 08:36:07 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EC88A1065670
	for <freebsd-net@freebsd.org>; Sun,  6 Dec 2009 08:36:07 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outH.internet-mail-service.net (outh.internet-mail-service.net
	[216.240.47.231])
	by mx1.freebsd.org (Postfix) with ESMTP id D04F38FC12
	for <freebsd-net@freebsd.org>; Sun,  6 Dec 2009 08:36:07 +0000 (UTC)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id B70D1961CA;
	Sun,  6 Dec 2009 00:36:07 -0800 (PST)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org
	(h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137])
	by idiom.com (Postfix) with ESMTP id 174C32D6010;
	Sun,  6 Dec 2009 00:36:07 -0800 (PST)
Message-ID: <4B1B6CFB.7040003@elischer.org>
Date: Sun, 06 Dec 2009 00:36:11 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Luigi Rizzo <rizzo@iet.unipi.it>
References: <933fa9790912040047k64aa11a7s736688e7382725ad@mail.gmail.com>
	<933fa9790912051124x77f33878tfe588c0cbdb1fe4@mail.gmail.com>
	<4B1B4728.2050308@elischer.org>
	<20091206084256.GB40585@onelab2.iet.unipi.it>
In-Reply-To: <20091206084256.GB40585@onelab2.iet.unipi.it>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org, Gleb Smirnoff <glebius@glebius.int.ru>,
	Lytochkin Boris <lytboris@gmail.com>
Subject: Re: FreeBSD 8: ipfw fwd and pf route-to broken?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Dec 2009 08:36:08 -0000

Luigi Rizzo wrote:
> On Sat, Dec 05, 2009 at 09:54:48PM -0800, Julian Elischer wrote:
>> Lytochkin Boris wrote:
>>> Hi!
>>>
>>> sbin/ipfw in RELENG_8 do not set sin_len in fwd rule, so sockaddr_in
>> >from ipfw is sucked into rtalloc1_fib() at last with zero length and
>>> is routed to lo0 instead of correct interface.
>>> Returning sin_len into sbin/ipfw resolves issue.
>>>
>>> sin_len setting was removed in revision 1.146 by luigi.
>>>
>>> What is correct solution? Return sin_len setting into sbin/ipfw or
>>> something else?
> 
> if you have tested that putting back sin_len fixes the problem
> then it should definitely go in again.
> interesting bug, i will put it a fix as soon as i have a chance
> 
> thanks
> luigi


if this indeed breaks fwd in 8.0 it's a big deal and needs to go into 
the errata.