From owner-cvs-src@FreeBSD.ORG Sat Mar 17 06:22:53 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0EBCE16A401 for ; Sat, 17 Mar 2007 06:22:53 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.235]) by mx1.freebsd.org (Postfix) with ESMTP id AFF9913C44C for ; Sat, 17 Mar 2007 06:22:52 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wx-out-0506.google.com with SMTP id s18so728931wxc for ; Fri, 16 Mar 2007 23:22:52 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qbqkKSP4g654tkCS2LCF7xvDbhDfk5O40kCA16zu2fjiS+UUYvd2jyzioonYo4D0xfGHHT1yn1Jsjoiy3wgSOI7uF9B4EdAcupInrc+Yq5w2awqS24P/An78TpLGBSPkiGesx14Lh1XELtN8fQ9R2/Q1Y2xmjtN9Hn8MFQkymRc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=baIlk1bX1WzERTucCz9wq8t8aekFRE9F8aCm4GExMs9vzXXEJsMmlK2H5f9IIsNykXmwL1fz7xKQLld9oK6Nir98Vn728zWXyof4C9+C8Tk3aC8Jd0s5fvRAo8VgUVoa5HJxTwIY0unwV/7pKdfjx18ZZqFCA+fvY19jwaqZ3x0= Received: by 10.90.100.2 with SMTP id x2mr2596881agb.1174112572012; Fri, 16 Mar 2007 23:22:52 -0700 (PDT) Received: by 10.90.25.1 with HTTP; Fri, 16 Mar 2007 23:22:51 -0700 (PDT) Message-ID: Date: Fri, 16 Mar 2007 23:22:51 -0700 From: "Kip Macy" To: "Andre Oppermann" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703151559.l2FFxSG7088256@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp.h tcp_input.c tcp_output.c tcp_syncache.c tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2007 06:22:53 -0000 It appears that the problem is on line 1229 - you increment ip->ip_len unconditionally, but if its an inet6 connection *ip is NULL. I'll see if I can't fix. Of course there is another bug her because this isn't an ipv6 connection. On 3/16/07, Kip Macy wrote: > I get a panic in tcp_syncache when I fire up xemacs over "ssh -Y". > > -Kip > > On 3/15/07, Andre Oppermann wrote: > > andre 2007-03-15 15:59:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet tcp.h tcp_input.c tcp_output.c > > tcp_syncache.c tcp_var.h > > Log: > > Consolidate insertion of TCP options into a segment from within tcp_output() > > and syncache_respond() into its own generic function tcp_addoptions(). > > > > tcp_addoptions() is alignment agnostic and does optimal packing in all cases. > > > > In struct tcpopt rename to_requested_s_scale to just to_wscale. > > > > Add a comment with quote from RFC1323: "The Window field in a SYN (i.e., > > a or ) segment itself is never scaled." > > > > Reviewed by: silby, mohans, julian > > Sponsored by: TCP/IP Optimization Fundraise 2005 > > > > Revision Changes Path > > 1.35 +5 -2 src/sys/netinet/tcp.h > > 1.317 +2 -2 src/sys/netinet/tcp_input.c > > 1.126 +199 -146 src/sys/netinet/tcp_output.c > > 1.105 +43 -75 src/sys/netinet/tcp_syncache.c > > 1.140 +14 -8 src/sys/netinet/tcp_var.h > > >