From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 7 04:30:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9EA61FE5 for ; Wed, 7 Aug 2013 04:30:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7F3352538 for ; Wed, 7 Aug 2013 04:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r774U0Ka058213 for ; Wed, 7 Aug 2013 04:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r774U0br058210; Wed, 7 Aug 2013 04:30:00 GMT (envelope-from gnats) Resent-Date: Wed, 7 Aug 2013 04:30:00 GMT Resent-Message-Id: <201308070430.r774U0br058210@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sean Bruno Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 94E60FCC for ; Wed, 7 Aug 2013 04:26:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8304A2529 for ; Wed, 7 Aug 2013 04:26:03 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r774Q3FK060303 for ; Wed, 7 Aug 2013 04:26:03 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r774Q3im060295; Wed, 7 Aug 2013 04:26:03 GMT (envelope-from nobody) Message-Id: <201308070426.r774Q3im060295@oldred.freebsd.org> Date: Wed, 7 Aug 2013 04:26:03 GMT From: Sean Bruno To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/181101: [patch] audio/clementine needs patch for deprecated g_type_init() X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Aug 2013 04:30:00 -0000 >Number: 181101 >Category: ports >Synopsis: [patch] audio/clementine needs patch for deprecated g_type_init() >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 07 04:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Sean Bruno >Release: -CURRENT >Organization: FreeBSD Project >Environment: FreeBSD alice 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r254018: Tue Aug 6 19:17:07 PDT 2013 sbruno@alice:/usr/obj/usr/src/sys/ALICE amd64 >Description: GLIB bumped its version so that after 2.36.0 g_type_init() needs to be ignored. ref: http://code.google.com/p/clementine-player/source/detail?r=2cdbe9ea8247 Without this patch, the port emits the following build error: main.cpp:268:3: error: ‘void g_type_init()’ is deprecated (declared at /usr/include/glib-2.0/gobject/gtype.h:669) [-Werror=deprecated-declarations] g_type_init(); >How-To-Repeat: build audio/clemetine-player >Fix: Apply patch: Patch attached with submission follows: --- src/main.cpp 2012-11-18 00:51:27.000000000 -0800 +++ ../../work.fixed/clementine-1.1.1/src/main.cpp 2013-08-06 20:55:06.046505976 -0700 @@ -265,7 +265,9 @@ #endif // This makes us show up nicely in gnome-volume-control - g_type_init(); +#if !GLIB_CHECK_VERSION(2, 36, 0) + g_type_init(); // Deprecated in glib 2.36.0 +#endif g_set_application_name(QCoreApplication::applicationName().toLocal8Bit()); RegisterMetaTypes(); >Release-Note: >Audit-Trail: >Unformatted: