From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 27 11:40:08 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DD7D1065695 for ; Wed, 27 Oct 2010 11:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 474278FC23 for ; Wed, 27 Oct 2010 11:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9RBe8oA081844 for ; Wed, 27 Oct 2010 11:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9RBe8b1081843; Wed, 27 Oct 2010 11:40:08 GMT (envelope-from gnats) Resent-Date: Wed, 27 Oct 2010 11:40:08 GMT Resent-Message-Id: <201010271140.o9RBe8b1081843@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Thinker K.F. Li" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E61B1065670 for ; Wed, 27 Oct 2010 11:30:14 +0000 (UTC) (envelope-from thinker.li@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id E45428FC1A for ; Wed, 27 Oct 2010 11:30:13 +0000 (UTC) Received: by gxk9 with SMTP id 9so296119gxk.13 for ; Wed, 27 Oct 2010 04:30:13 -0700 (PDT) Received: by 10.150.97.14 with SMTP id u14mr6513911ybb.382.1288179013069; Wed, 27 Oct 2010 04:30:13 -0700 (PDT) Received: from eeebox.branda.to (61-231-70-230.dynamic.hinet.net [61.231.70.230]) by mx.google.com with ESMTPS id r25sm7575957yhc.0.2010.10.27.04.30.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 27 Oct 2010 04:30:11 -0700 (PDT) Received: from eeebox.branda.to (localhost [127.0.0.1]) by eeebox.branda.to (8.14.4/8.14.4) with ESMTP id o9RBUa1m016168; Wed, 27 Oct 2010 19:30:37 +0800 (CST) (envelope-from thinker@branda.to) Received: (from root@localhost) by eeebox.branda.to (8.14.4/8.14.4/Submit) id o9RBUaoa016167; Wed, 27 Oct 2010 19:30:36 +0800 (CST) (envelope-from thinker) Message-Id: <201010271130.o9RBUaoa016167@eeebox.branda.to> Date: Wed, 27 Oct 2010 19:30:36 +0800 (CST) From: "Thinker K.F. Li" Sender: Thinker Li To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: linpct@gmail.com Subject: ports/151775: [PATCH] www/node: [SUMMARIZE CHANGES] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2010 11:40:08 -0000 >Number: 151775 >Category: ports >Synopsis: [PATCH] www/node: [SUMMARIZE CHANGES] >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 27 11:40:07 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Thinker K.F. Li >Release: FreeBSD 9.0-CURRENT i386 >Organization: >Environment: System: FreeBSD eeebox.branda.to 9.0-CURRENT FreeBSD 9.0-CURRENT #12: Mon Oct 11 18:03:28 CST 2010 >Description: When you build an plugin for nodejs with node-waf, and give different directory for source and build, it maybe fault. node-waf would compute a relative path from build directory to source directory. It works if no symbolic link in the absolute path of build directory. But, it is fault when a symbolic link in the absolute path. For example, for most FreeBSD user, their home directory is in /usr/home/XXXX. But, there is a symbolic link /home to /usr/home. If your home is specified with /home/XXXX and another path is /usr/OOOO, node-waf will get a relative path from /home/XXXX to /usr/OOOO as ../../usr/OOOO. It suppose /home/XXXX/../../ is root directory, but it is actually /usr. So, absolute path of relative path ../../usr/OOOO in /home/XXXX is actually /usr/usr/OOOO, it is different from the expected one; /usr/OOOO. Added file(s): - files/patch-wafadmin-Node.py Port maintainer (linpct@gmail.com) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- node-0.2.4.patch begins here --- diff -ruN --exclude=CVS /usr/ports/www/node/files/patch-wafadmin-Node.py /usr/ports/www/node.new/files/patch-wafadmin-Node.py --- /usr/ports/www/node/files/patch-wafadmin-Node.py 1970-01-01 08:00:00.000000000 +0800 +++ /usr/ports/www/node.new/files/patch-wafadmin-Node.py 2010-10-27 18:30:17.000000000 +0800 @@ -0,0 +1,15 @@ +--- tools/wafadmin/Node.py.orig 2010-10-25 05:45:39.000000000 +0800 ++++ tools/wafadmin/Node.py 2010-10-27 18:30:12.000000000 +0800 +@@ -349,6 +349,12 @@ + if self == from_node: return '.' + if from_node.parent == self: return '..' + ++ from_node_path = from_node.abspath() ++ from_node_realpath = os.path.realpath(from_node_path) ++ if from_node_path != from_node_realpath: ++ from_node = self.__class__.bld.root.find_dir(from_node_realpath) ++ return self.relpath_gen(from_node) ++ + # up_path is '../../../' and down_path is 'dir/subdir/subdir/file' + ancestor = self.find_ancestor(from_node) + lst = [] --- node-0.2.4.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: