From owner-freebsd-bugs@FreeBSD.ORG Tue May 5 22:41:51 2015 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EA65848A for ; Tue, 5 May 2015 22:41:51 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D29C11693 for ; Tue, 5 May 2015 22:41:51 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t45Mfp9k039009 for ; Tue, 5 May 2015 22:41:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192837] [patch] su(1) does not need to fork; it causes terminal problems Date: Tue, 05 May 2015 22:41:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ta0kira@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2015 22:41:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192837 --- Comment #3 from Kevin Barry --- (In reply to Jilles Tjoelker from comment #2) "The fork is required so that PAM may be shut down correctly." This seems reasonable. I assume that the PAM shutdown needs to happen after the child exits? "The setpgid code is there for csh. See SVN r153985 and previous for details. Apparently csh does not make itself a process group leader when it is interactive and job control is enabled. Fixing this is harder than it seems." Is this a bug or a feature of csh? It seems a bit extreme to influence the behavior of su based on an idiosyncrasy of one of the countless possible commands that it can execute. It seems perfectly fine for csh to not become the process group leader in that situation, so is there really a need to force that to be the case when executing it from su? Would it break existing code/usage to: 1) remove all of the pg-related code in su; and/or 2) update csh to make it become process group leader if it isn't already the session leader? -- You are receiving this mail because: You are the assignee for the bug.