From owner-cvs-all Thu Sep 20 8: 7:11 2001 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id 1A51337B41C; Thu, 20 Sep 2001 08:07:00 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id D2D8481D07; Thu, 20 Sep 2001 10:06:54 -0500 (CDT) Date: Thu, 20 Sep 2001 10:06:54 -0500 From: Alfred Perlstein To: Brian Somers Cc: Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net rtsock.c Message-ID: <20010920100654.W61456@elvis.mu.org> References: <200109201353.f8KDrpR40559@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200109201353.f8KDrpR40559@hak.lan.Awfulhak.org>; from brian@freebsd-services.com on Thu, Sep 20, 2001 at 02:53:51PM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Brian Somers [010920 08:54] wrote: > > ru 2001/09/20 01:25:25 PDT > > > > Modified files: > > sys/net rtsock.c > > Log: > > Use the current process's credentials rather than socket's cached. > > If the process drops its super-user privileges, we certainly don't > > want to allow it to modify routing tables. > > > > Discussed with: rwatson > > > > Revision Changes Path > > 1.58 +3 -3 src/sys/net/rtsock.c > > I can't upgrade any of my current boxes at the moment, but I suspect > this *may* break usr.sbin/ppp/arp.c (the write() on line 136 needs to > change to ID0write()). > > This can be tested by setting up a dialin to be assigned an IP address > that's part of a LAN that's connected to the server, and adding > ``enable proxy'' to the server config. > > If you can't test it right now, could you change the write() to ID0 > write() and I'll check things when I'm in a more stable position ? I know this change was done in the interests of security, however traditionally, holding and using an open descriptor that was opened at a higher privledge level is the way UNIX has worked. I think this ought to be backed out. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message