From owner-svn-src-projects@FreeBSD.ORG Tue Feb 25 01:48:08 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 241E5EF3; Tue, 25 Feb 2014 01:48:08 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E91C11FFC; Tue, 25 Feb 2014 01:48:07 +0000 (UTC) Received: from jre-mbp.elischer.org (ppp121-45-232-70.lns20.per1.internode.on.net [121.45.232.70]) (authenticated bits=0) by vps1.elischer.org (8.14.7/8.14.7) with ESMTP id s1P1lsjQ051012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 24 Feb 2014 17:47:58 -0800 (PST) (envelope-from julian@freebsd.org) Message-ID: <530BF645.2000209@freebsd.org> Date: Tue, 25 Feb 2014 09:47:49 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Andrew Turner , src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r262378 - projects/arm64/sys/boot/arm64/efi References: <201402231844.s1NIiAkE072754@svn.freebsd.org> In-Reply-To: <201402231844.s1NIiAkE072754@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2014 01:48:08 -0000 On 2/24/14, 2:44 AM, Andrew Turner wrote: > Author: andrew > Date: Sun Feb 23 18:44:10 2014 > New Revision: 262378 > URL: http://svnweb.freebsd.org/changeset/base/262378 > > Log: > Use the stack provided by the UEFI firmware > > Modified: > projects/arm64/sys/boot/arm64/efi/start.S > > Modified: projects/arm64/sys/boot/arm64/efi/start.S > ============================================================================== > --- projects/arm64/sys/boot/arm64/efi/start.S Sun Feb 23 18:41:07 2014 (r262377) > +++ projects/arm64/sys/boot/arm64/efi/start.S Sun Feb 23 18:44:10 2014 (r262378) > @@ -137,12 +137,7 @@ section_table: > > .globl _start > _start: > - /* Set up the stack */ > - adr x29, init_stack > - mov x28, INIT_STACK_SIZE > - add x29, x29, x28 > - mov sp, x29 > - > + /* Save the boot params to the stack */ maybe you might add some information in a comment about how big the stack is, and what the UEFI spec says about it, > stp x0, x1, [sp, #-16]! > > adr x0, __bss_start >