From owner-svn-src-head@FreeBSD.ORG Thu Nov 15 20:26:09 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 65F448B9 for ; Thu, 15 Nov 2012 20:26:09 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id C9A588FC0C for ; Thu, 15 Nov 2012 20:26:08 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id gg13so2041833lbb.13 for ; Thu, 15 Nov 2012 12:26:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=kTHr20RO0ZUJ8Y+eTfMzTOp8AqE7mYqvwmwr9t9ZB18=; b=dI9GuKB99y8Ik4cjnsVmTppThbsvXwXfJAlycnlwcY874HfYgVlfM8dFQXrabh9QD7 ap1QZjw4T3wz7muwUMl2ZLED+qN+FmLM1iniV6G1gGmWvlm4Jq5tQCXNWP0UlnSh1yKV YFFGA1VLNyR+FHmDAqqooXkMH8J+aU4Tu3Hfw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=kTHr20RO0ZUJ8Y+eTfMzTOp8AqE7mYqvwmwr9t9ZB18=; b=OyjSsQ1f69SpFz1U0NG5x2PPRgNIRWH3rzIVJL4ZPb2gMPxkUhp4CRJHJJQpCldnZ8 lRc0iLH3ww0Kp/MGpAYwAliscPL8k0hgL2CU/YkrQuPkINrb7L9OUllO/vb4EDo10kc0 GiO5uh0lGWJxTQtB8wtREevBHUcf052Xnh+WQXvylnfKFt6OF+yxY1DOj/RfG+ftX1q3 2WQsP3PckNgk2LrMIms4/k+HSamfKYSDOHZsHMACS0v+m/hIbX0IrDCqhAHLxxNA7QWD ddagyqikPvAkjFrTvlHQWzUQf3UHiYMqHOiic+2a/svGTzRqoyjlpK9Rp3QWo4YbwOTR 8mVQ== Received: by 10.112.104.2 with SMTP id ga2mr1106513lbb.48.1353011167116; Thu, 15 Nov 2012 12:26:07 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.166 with HTTP; Thu, 15 Nov 2012 12:25:35 -0800 (PST) In-Reply-To: <20121115192255.GH73505@kib.kiev.ua> References: <201211151849.qAFInHeU039083@svn.freebsd.org> <20121115192255.GH73505@kib.kiev.ua> From: Eitan Adler Date: Thu, 15 Nov 2012 15:25:35 -0500 X-Google-Sender-Auth: WidrpgXdyGSCVNHOaxXECLrdmHg Message-ID: Subject: Re: svn commit: r243095 - head/sys/dev/agp To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmiKFbTGEQieLf9Qwp+FXdavrz+WXRA+BKzLxjS382+TCpXEN5EkaQbAIKl1e6A4SEkKgLR Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2012 20:26:09 -0000 On 15 November 2012 14:22, Konstantin Belousov wrote: > On Thu, Nov 15, 2012 at 06:49:17PM +0000, Eitan Adler wrote: >> Author: eadler >> Date: Thu Nov 15 18:49:17 2012 >> New Revision: 243095 >> URL: http://svnweb.freebsd.org/changeset/base/243095 >> >> Log: >> Remove unneeded header from agp: opt_bus.h >> >> Tested with "make universe" > make universe cannot prove anything about usefulness of the removed include, > just because *_opt.h files contains only defines, which are used later > by the code like This is a good point. In this case I had done the manual review as well. "make universe" was an additional check. > If you are removing the option include, the module Makefile should be > adjusted too. :-\ I had sent this to Colin but forgot to include it in my final commit. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams