From owner-freebsd-hackers Sat Mar 1 17:55:11 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA12918 for hackers-outgoing; Sat, 1 Mar 1997 17:55:11 -0800 (PST) Received: from root.com (implode.root.com [198.145.90.17]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id RAA12913 for ; Sat, 1 Mar 1997 17:55:09 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by root.com (8.8.5/8.6.5) with SMTP id RAA00329; Sat, 1 Mar 1997 17:56:24 -0800 (PST) Message-Id: <199703020156.RAA00329@root.com> X-Authentication-Warning: implode.root.com: localhost [127.0.0.1] didn't use HELO protocol To: "David S. Miller" cc: netdev@roxanne.nuclecu.unam.mx, hackers@FreeBSD.ORG Subject: Re: ok, final sockhash changes, new diff In-reply-to: Your message of "Sat, 01 Mar 1997 20:02:55 EST." <199703020102.UAA09468@jenolan.caipgeneral> From: David Greenman Reply-To: dg@root.com Date: Sat, 01 Mar 1997 17:56:24 -0800 Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Reply-To: dg@root.com > Date: Sat, 01 Mar 1997 16:59:21 -0800 > > Hmmm. It seems that it might be better to add in the laddr if it > contains additional variable information, but I don't see how not > doing so would be a degenerate case when having a lot of IP > aliases. The faddr, lport, and fport are still just as variable as > in the non-lots-of-aliases case, so the hash distribution should be > the same. > >Good point, but alas there was a reason I considered it useful to add >in the laddr to the hash, give me some time and I'll remember what the >reason exactly was (it happens to cost nothing anyways ;-). The reason just occured to me: In the case of a server with googols of IP aliases, the {faddr, lport, fport} are all the same (faddr and fport are wildcards) for the listening sockets of a given service (say http)...so the only thing unique is the laddr, which if not included in the hash, will cause all of the listening sockets to be hashed to the same bucket. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project