From owner-svn-ports-all@freebsd.org  Mon Jan 30 18:05:17 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7EBECC7C85;
 Mon, 30 Jan 2017 18:05:17 +0000 (UTC)
 (envelope-from mandree@FreeBSD.org)
Received: from mandree.no-ip.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A851611DB;
 Mon, 30 Jan 2017 18:05:17 +0000 (UTC)
 (envelope-from mandree@FreeBSD.org)
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
 by apollo.emma.line.org (Postfix) with ESMTP id 0F23A23CEE2;
 Mon, 30 Jan 2017 19:05:09 +0100 (CET)
Subject: Re: svn commit: r432789 - in head/graphics: rawtherapee
 rawtherapee-devel
To: marino@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201701291734.v0THYrKF093793@repo.freebsd.org>
 <5a60e31f-dfbe-708b-91ac-c8ac2c9d8dc8@FreeBSD.org>
 <26beab27-ea3b-6891-69ee-ebadd071013f@marino.st>
From: Matthias Andree <mandree@FreeBSD.org>
Message-ID: <d9644907-265c-291d-1713-1d08df05970a@FreeBSD.org>
Date: Mon, 30 Jan 2017 19:05:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <26beab27-ea3b-6891-69ee-ebadd071013f@marino.st>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jan 2017 18:05:18 -0000

Am 30.01.2017 um 14:20 schrieb John Marino:
> On 1/30/2017 03:07, Mathieu Arnold wrote:
>> Le 29/01/2017 à 18:34, Matthias Andree a écrit :
>>> +.if ${OSVERSION} < 1030000
>>> +IGNORE=    is only for supported FreeBSD releases
>>> +.endif
>>
>>> +.if ${OSVERSION} < 1030000
>>> +IGNORE=    is only for supported FreeBSD releases
>>> +.endif
>>
>>
>> The ports framework already has a check for unsupported releases, these
>> are not needed.
>>
> 
> With a caveat.  The ports framework is overrideable with
> ALLOW_UNSUPPORTED_SYSTEMS and this one is not.  Morever, rawtherapee may
> specifically draw the line at 10.3 and not "unsupported releases".  I
> guess only mandree knows for sure.

Thanks for this discussion, Mathieu and John.

Basically the idea was to kill building on unsupported systems, so I
will remove this duplicate code next time I commit.  No need to
duplicate code.  If someone requests the port to force build on an
unsupported system, any PRs that come my way to ask for support for
decommissioned or deprecated systems will be closed as "rejected"
anyhow, so...

Dim@ answered on the "FreeBSD 12 i386 GCC" combo with a "don't expect
upstream" support... so I wonder if it's our ABI, but I don't mean to
take on yet another project.