From owner-svn-src-head@freebsd.org Wed Mar 7 18:20:20 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56A98F46EDE for ; Wed, 7 Mar 2018 18:20:20 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic311-36.consmr.mail.gq1.yahoo.com (sonic311-36.consmr.mail.gq1.yahoo.com [98.137.65.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D662085A2A for ; Wed, 7 Mar 2018 18:20:19 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1520446813; bh=H2fpxJYxR8Y7gk7hMU0VtNiZW9ietHk0qKIgMrpv5A4=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=P7/1nrl/OYhB4I3yo1MnwuTM7bMFQ1a55KlDl7s7JKIwHNxQWc4BwYlvJZRwx+VBNgrnM2okfYP84C4XbiGaYME5tjmDQd+ZdfwgETyc57t6R0CGg5EV4/iyRog8cHIL5o17cyPsVGSi7/A0x4XNPWSKjq67MN5ZOqJYNFxX7guesF1dfzerMe97Qm5NFo8Rn2uq2zXhaz7zL8/5b73dTVaPv++HIABhXKMwnWH1yWKzUH9hDjK3343ZO+ztxeAtGI6mjObbqO74dbpJ/EdD0CGKVjVat3F009I/dJr53CtgRD7BqF/QGqlhNy2R3K68G0BCWCqcGYIB3BpfI06/lg== X-YMail-OSG: 5N5TbQkVM1ktYN5bwcaBWdrVm0jzAL2SsnRTolUISD3b1LGcaKqHpXM4YYLWXwV .o7ZhC6kCxMoire1n349jkmCd_l7hX89fmO6DVEevuhjUkOoeE7Map9gcMALbod757vbDTDYbd9b fgGBEb1.ZKCMEg1gMsN3PI8frNNvdSjLUXV9VVXiEwsY_aE1pa46SPHfegbgxMe_7VigcKXdjpjx .kjAIG7mbimphWjFTK7W7AxnfkotK_gA84nh3AoqJESgAqVlEMLxdwh5s.JfDNmyljwL5QuAUDZj dFG1sNf1_p3q2B4uKOvwhQf9Dq6p.qL_OHc3mZFTZ3vSsZLAI8LHMaaNbL1l5j1vG0LoV.QDlUZb YziuMWShZrjhmsARzohKZ5DNigdCsqr28yHs7tg9t9gfCrXgWxBqKmqpGeJ2eqkoItMYno04Bo_h 7g.pwak66eHAvvQLhMz_L9RDsMvggGE5uQ6UHS_aMDwZUXKcu19DwJOMlDDMFDL9r2aalvBY4WER 1K0e07KwTgtQ- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Wed, 7 Mar 2018 18:20:13 +0000 Received: from smtp103.rhel.mail.gq1.yahoo.com (EHLO [192.168.0.5]) ([68.180.227.11]) by smtp407.mail.gq1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 3fe462febc7181c785a57f1c1e7e35dd; Wed, 07 Mar 2018 18:20:13 +0000 (UTC) Subject: Re: svn commit: r330601 - head/sys/i386/ibcs2 To: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201803071444.w27EiWBV053244@repo.freebsd.org> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: Date: Wed, 7 Mar 2018 13:20:14 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201803071444.w27EiWBV053244@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 18:20:20 -0000 FWIW ... ibcs2 is candidate for future removal. We tried to get some vendor interest in it but we failed and given this is very i386-specific it is probably not worth spending huge efforts on it. cloudabi seems to be, for all purposes, a better conceptual replacement. Pedro. On 07/03/2018 09:44, Eitan Adler wrote: > Author: eadler > Date: Wed Mar 7 14:44:32 2018 > New Revision: 330601 > URL: https://svnweb.freebsd.org/changeset/base/330601 > > Log: > sys: Fix a few potential infoleaks in cloudabi > > While there is no immediate leak, if the structure changes underneath > us, there might be in the future. > > Submitted by: Domagoj Stolfa > MFC After: 1 month > Sponsored by: DARPA/AFRL > > Modified: > head/sys/i386/ibcs2/ibcs2_ipc.c > > Modified: head/sys/i386/ibcs2/ibcs2_ipc.c > ============================================================================== > --- head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:41:29 2018 (r330600) > +++ head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:44:32 2018 (r330601) > @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v) > struct msqid_ds bs; > int error; > > + memset(&is, 0, sizeof(is)); > + > switch (uap->cmd) { > case IBCS2_IPC_STAT: > error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs); > @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v) > union semun semun; > register_t rval; > int error; > + > + memset(&is, 0, sizeof(is)); > > switch(uap->cmd) { > case IBCS2_IPC_STAT: >