From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Feb 24 14:26:36 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B5BF1337 for ; Tue, 24 Feb 2015 14:26:36 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9AD7391 for ; Tue, 24 Feb 2015 14:26:36 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1OEQanE077456 for ; Tue, 24 Feb 2015 14:26:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197975] textproc/mgdiff take MAINTAINERship Date: Tue, 24 Feb 2015 14:26:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: portmaster@bsdforge.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 14:26:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197975 --- Comment #4 from Chris Hutchinson --- (In reply to Jan Beich from comment #2) > Comment on attachment 153408 [details] > svn diff for textproc/mgdiff >=20 > > USES=3D imake motif > > USE_XORG=3D ice sm x11 xext xmu xp xt > >-SUB_FILES=3D pkg-message > >=20 > >+DESKTOP_ENTRIES=3D "mgdiff" "GUI front end to the UNIX diff command" \ > >+ "mgDIFF-48x48" \ > >+ "mgdiff" "GNOME;GTK;Motif;Development;System;" \ >=20 > Why the app is listed in GNOME and GTK categories but has no such > dependencies? It's just a standard template I use. No harm comes from listing them. No warnings will be emitted either. >=20 > >+WWW: http://BSDforge.com/projects/textproc/mgdiff/ >=20 > WWW doesn't match MASTER_SITES. Did you take upstream maintainership as w= ell? Upstream hasn't, to the best of my knowledge, *ever* provided a WWW. As a WWW wasn't provided in src, or the port, I felt others would benefit from having one. As to take upstream maintenance; I'm waiting to see if the original author expresses any objection (I've contacted him). >=20 > > post-install: > >- @${MKDIR} ${STAGEDIR}${PREFIX}/lib/X11/mgdiff > >- ${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/lib/X11/m= gdiff > >+ @${MKDIR} ${STAGEDIR}${PREFIX}/share/pixmaps > >+ ${CP} ${FILESDIR}/mgDIFF-48x48.xpm ${STAGEDIR}${PREFIX}/share/pixmaps/= mgDIFF-48x48.xpm >=20 > Why different case: mgDIFF vs. mgdiff? Cause it was easier for me to [visually] differentiate it. > share/pixmaps icons aren't themed, so > Icon=3Dmgdiff-48x48 in .desktop file won't match other colorless variants. > Here's a quick test for Gtk behavior via attachment 153255 [details] >=20 > $ icon-lookup > usage: icon-lookup icon_theme icon_name size flags >=20 > $ icon-lookup test mgdiff 0 0 > /usr/local/share/pixmaps/mgdiff.xpm > $ icon-lookup test mgdiff 48 0 > /usr/local/share/pixmaps/mgdiff.xpm >=20 > $ icon-lookup test mgdiff-48x48 0 0 > /usr/local/share/pixmaps/mgdiff-48x48.xpm > $ icon-lookup test mgdiff-48x48 48 0 > /usr/local/share/pixmaps/mgdiff-48x48.xpm Thanks! >=20 > >+ ${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/share/pix= maps >=20 > Note, XBM format isn't supported by Icon Theme spec (v0.11). And mgdiff.x= bm > is already embedded in the binary. >=20 > $ fgrep -r .xbm . > ./Makefile.ini:MISC =3D Makefile Imakefile mgdiff.xbm Mgdiff.ad > ./Makefile.ini:mgdiff.o : mgdiff.c mgdiff.h externs.h patchlevel.h > mgdiff.xbm > ./mgdiff.c:#include "mgdiff.xbm" I intended to incorporate the new colored one globally. But need to add more applications to the box I'm developing on, in order to create the SVG format I intend to use. The box I develop on is slated for an update [FreeBSD] so decided to wait until then, before adding the additional applications. The one I provided, will suffice during the [short] interim. Thanks for all your attention to this, Jan Beich. --Chris --=20 You are receiving this mail because: You are the assignee for the bug.=