From nobody Tue Mar 21 15:08:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pgw3P1jWMz40QQ2; Tue, 21 Mar 2023 15:08:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pgw3N6cx7z3NSJ; Tue, 21 Mar 2023 15:08:32 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 32LF8PcM028715 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 21 Mar 2023 17:08:28 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 32LF8PcM028715 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 32LF8OWS028705; Tue, 21 Mar 2023 17:08:24 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 21 Mar 2023 17:08:24 +0200 From: Konstantin Belousov To: Corvin =?utf-8?B?S8O2aG5l?= Cc: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d780c6a6abb5 - main - x86/pci_early_quirks: Support Intel 11th+ gen Message-ID: References: <202303202047.32KKlrbx083372@gitrepo.freebsd.org> <5d5698b1fdd6699d27a158c87cab868d0ea8046a.camel@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5d5698b1fdd6699d27a158c87cab868d0ea8046a.camel@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4Pgw3N6cx7z3NSJ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, Mar 21, 2023 at 03:20:12PM +0100, Corvin Köhne wrote: > On Tue, 2023-03-21 at 16:02 +0200, Konstantin Belousov wrote: > > On Mon, Mar 20, 2023 at 08:47:53PM +0000, Jean-Sébastien Pédron > > wrote: > > > The branch main has been updated by dumbbell: > > > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=d780c6a6abb5275c8c7219539553d51ac94a023e > > > > > > commit d780c6a6abb5275c8c7219539553d51ac94a023e > > > Author:     Jean-Sébastien Pédron > > > AuthorDate: 2023-03-13 14:28:22 +0000 > > > Commit:     Jean-Sébastien Pédron > > > CommitDate: 2023-03-20 20:47:36 +0000 > > > > > >     x86/pci_early_quirks: Support Intel 11th+ gen > > >     > > >     Newer Intel CPUs/iGPUs use a new method to determine the base > > > address of > > >     the stolen memory. This code was ported from Linux. > > >     > > >     Reviewed by:    manu > > >     Approved by:    manu > > >     Differential Revision:  https://reviews.freebsd.org/D39057 > > > --- > > >  sys/x86/pci/pci_early_quirks.c | 26 ++++++++++++ > > >  sys/x86/pci/pci_early_quirks.h | 95 > > > ++++++++++++++++++++++++++++++++++++++++++ > > >  2 files changed, 121 insertions(+) > > Is this stuff still needed or useful?  When it was added, the claim > > was that > > it would be soon used to reserve regions of physical memory that > > buggy BIOSes > > did not.  That never happen. > > > > If the only current consumer of the stolen memory calculations are in > > drm > > kmods, wouldn't it be better to move the code there? > > I'm going to make use of intel_graphics_stolen_base and > intel_graphics_stolen_size for GPU passthrough of bhyve vms. See > https://reviews.freebsd.org/D26209 Then perhaps the quirks should be moved to separate module. Both your stuff and drm could depend on it.