From owner-svn-src-all@FreeBSD.ORG Thu Jun 24 20:20:04 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B107106566B; Thu, 24 Jun 2010 20:20:04 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from argol.doit.wisc.edu (argol.doit.wisc.edu [144.92.197.212]) by mx1.freebsd.org (Postfix) with ESMTP id 28A698FC0A; Thu, 24 Jun 2010 20:20:04 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0L4J0000ACHFHS00@smtpauth3.wiscmail.wisc.edu>; Thu, 24 Jun 2010 15:20:03 -0500 (CDT) Received: from anacreon.physics.wisc.edu (anacreon.physics.wisc.edu [128.104.160.176]) by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0L4J00JL1CHBKX50@smtpauth3.wiscmail.wisc.edu>; Thu, 24 Jun 2010 15:20:00 -0500 (CDT) Date: Thu, 24 Jun 2010 15:19:59 -0500 From: Nathan Whitehorn In-reply-to: <201006241753.o5OHrPnU058288@svn.freebsd.org> To: Warner Losh Message-id: <20100624151959.6b00bfdd@anacreon.physics.wisc.edu> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; powerpc64-portbld-freebsd9.0) X-Spam-Report: AuthenticatedSender=yes, SenderIP=128.104.160.176 X-Spam-PmxInfo: Server=avs-12, Version=5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2010.6.24.200915, SenderIP=128.104.160.176 References: <201006241753.o5OHrPnU058288@svn.freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209511 - head X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2010 20:20:04 -0000 On Thu, 24 Jun 2010 17:53:25 +0000 (UTC) Warner Losh wrote: > Author: imp > Date: Thu Jun 24 17:53:25 2010 > New Revision: 209511 > URL: http://svn.freebsd.org/changeset/base/209511 > > Log: > Merge from tbemd: > > use MACHINE_CPUARCH instead of MACHINE_CPU since the sources for the > CSU is based on MACHINE_CPUARCH > > Reviewed by: arch@ (twice) This is not always true. For example, on powerpc64, the ABI is different enough between powerpc and powerpc64, which share a CPUARCH, that the csu code shares very little. I can work around this with Makefile or preprocessor hacks, of course, but would be it be possible here instead to check for MACHINE_ARCH before falling back to MACHINE_CPUARCH? -Nathan