From owner-freebsd-bugs@FreeBSD.ORG Sat Feb 26 19:10:22 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6491D16A4CE for ; Sat, 26 Feb 2005 19:10:22 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15F2B43D62 for ; Sat, 26 Feb 2005 19:10:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1QJALmi072560 for ; Sat, 26 Feb 2005 19:10:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1QJALCa072559; Sat, 26 Feb 2005 19:10:21 GMT (envelope-from gnats) Resent-Date: Sat, 26 Feb 2005 19:10:21 GMT Resent-Message-Id: <200502261910.j1QJALCa072559@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gavin Atkinson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EDA916A4CE for ; Sat, 26 Feb 2005 19:00:56 +0000 (GMT) Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6874943D39 for ; Sat, 26 Feb 2005 19:00:55 +0000 (GMT) (envelope-from ga9@buffy.york.ac.uk) Received: from buffy.york.ac.uk (buffy.york.ac.uk [144.32.226.160]) by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id j1QJ0rD7002585 for ; Sat, 26 Feb 2005 19:00:53 GMT Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.13.1/8.13.1) with ESMTP id j1QJ0rle065645 for ; Sat, 26 Feb 2005 19:00:53 GMT (envelope-from ga9@buffy.york.ac.uk) Received: (from ga9@localhost) by buffy.york.ac.uk (8.13.1/8.13.1/Submit) id j1QJ0rd0065644; Sat, 26 Feb 2005 19:00:53 GMT (envelope-from ga9) Message-Id: <200502261900.j1QJ0rd0065644@buffy.york.ac.uk> Date: Sat, 26 Feb 2005 19:00:53 GMT From: Gavin Atkinson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/78125: Remove unused code from idmapd.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Gavin Atkinson List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Feb 2005 19:10:22 -0000 >Number: 78125 >Category: bin >Synopsis: Remove unused code from idmapd.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Feb 26 19:10:21 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Gavin Atkinson >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: System: FreeBSD buffy.york.ac.uk 5.3-STABLE FreeBSD 5.3-STABLE #0: Sat Feb 12 20:42:16 GMT 2005 root@buffy.york.ac.uk:/usr/obj/usr/src/sys/BUFFY i386 >Description: In src/sbin/idmapd/idmapd.c, there's some error-checking code which can never evaluate to true, and indeed seems to be left over from previous code (judging by the error message). >How-To-Repeat: n/a >Fix: --- idmapd.patch begins here --- Index: src/sbin/idmapd/idmapd.c =================================================================== RCS file: /usr/cvs/src/sbin/idmapd/idmapd.c,v retrieving revision 1.5 diff -u -r1.5 idmapd.c --- src/sbin/idmapd/idmapd.c 15 Apr 2004 16:12:12 -0000 1.5 +++ src/sbin/idmapd/idmapd.c 26 Feb 2005 16:27:41 -0000 @@ -339,12 +339,6 @@ TAILQ_INIT(&upcall_q); - if (error) { - perror("sigaction"); - exit(1); - } - - fd = open(DEV_PATH, O_RDWR, S_IRUSR | S_IWUSR); if (fd < 0) { --- idmapd.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: