From nobody Sat Jul 16 18:46:58 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Llcf46cxZz4T101; Sat, 16 Jul 2022 18:47:08 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Llcf45Fndz40NT; Sat, 16 Jul 2022 18:47:08 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 26GIl0Ut058133 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 16 Jul 2022 11:47:00 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 26GIkwXC058132; Sat, 16 Jul 2022 11:46:58 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Sat, 16 Jul 2022 11:46:58 -0700 From: Gleb Smirnoff To: Mike Karels Cc: Mateusz Guzik , Mike Karels , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: efe58855f3ea - main - IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8 Message-ID: References: <202207131449.26DEnh0G089612@gitrepo.freebsd.org> <90326A36-85E7-49E7-944A-AED1EEC4C46B@karels.net> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90326A36-85E7-49E7-944A-AED1EEC4C46B@karels.net> X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4Llcf45Fndz40NT X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, Jul 16, 2022 at 10:13:46AM -0500, Mike Karels wrote: M> > This cause LINT-NOIP builds to fail: M> > ld: error: undefined symbol: vnet_entry_in_loopback_mask M> >>>> referenced by ib_cma.c M> >>>> ib_cma.o:(rdma_destroy_id) M> >>>> referenced by ib_cma.c M> >>>> ib_cma.o:(rdma_resolve_addr) M> >>>> referenced by ib_cma.c M> >>>> ib_cma.o:(rdma_bind_addr) M> >>>> referenced 11 more times M> M> Yuck. The Infiniband code isn’t ifdefed for INET (or INET6) and just M> uses things. One of its Linux compat shims uses IN_LOOPBACK, which now M> refers to a mask field via VNET. I can either add one #ifdef INET to M> ib_cma.c, or remove OFED from LINT-NOIP. I suppose I should add the M> #ifdef; any other opinions? I think the right thing to do will be to add ifdefs to cma_loopback_addr(). The beginning of the file should be augmented with including opt_inet.h and opt_inet6.h, too. -- Gleb Smirnoff