From owner-svn-src-head@FreeBSD.ORG Fri May 10 12:44:08 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 16EDDB65 for ; Fri, 10 May 2013 12:44:08 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id E4CF77A4 for ; Fri, 10 May 2013 12:44:07 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id kx1so2897856pab.27 for ; Fri, 10 May 2013 05:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=6W1EL1mIL7G7tZ2U7BFbzKuFNlMLw0HxhYs/CBKnjXc=; b=jQMzD6JWt1WumkjVSc3ko3tH7B5P8Q9/JFKnp+f4dErhf7zV2sKSWCcfwvp2E7idAG Cd2YXalQroHn8asXetBDIVz28RcySvC7ADi4Cr5gyJAeHQGLpeIXDUmU531YhHn47mvd b7bkO1fEHnHPxAYVUYcUyt6R6eNqRp8ChkwcE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=6W1EL1mIL7G7tZ2U7BFbzKuFNlMLw0HxhYs/CBKnjXc=; b=PLEIIr1Yn8OztbEUHqb57cf3yCy+zgPKujGxrRg+795MAnxjR2E6Ii1EdQjITA31FB SCQS4/DJE1wLCZDju+DIp13trG5lr6VW0sGKCwDmeo5aPfQW8+O3RI/4f73VINnoy+L+ J4QH2TL6UwTKc2ehhL/qmTXOmILZaxw86raIGFmQVhuDLFQbBy5b8tNfuEcJ44n16FyG qripOzSO1XovnSMEaxEA9ANHDvFhKYcONMmIqvh7qr3J9WAQUp/dFiLEaMiJb2zvQZ+m CtvqhqEk6X7p7XtG/lkZO5kgFqwfwZ8lPvTNMHoj7cG/5i1YXKQxwmKf/lT5VM+zHjyz moBA== X-Received: by 10.66.121.234 with SMTP id ln10mr16909965pab.129.1368189847447; Fri, 10 May 2013 05:44:07 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.159.97 with HTTP; Fri, 10 May 2013 05:43:37 -0700 (PDT) In-Reply-To: <20130510074235.GA19945@FreeBSD.org> References: <201305100342.r4A3gmc9080595@svn.freebsd.org> <20130510074235.GA19945@FreeBSD.org> From: Eitan Adler Date: Fri, 10 May 2013 08:43:37 -0400 X-Google-Sender-Auth: Su1AY8ekaWXjIILs86R-Kc4_hQc Message-ID: Subject: Re: svn commit: r250430 - head/sbin/dmesg To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmbXE+dWopj/8v9WLMy2ii7r/p+JcKPwuykMWf8rfV/jxTt9SzcW7c29KTgQMqSeKFlINF3 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 May 2013 12:44:08 -0000 On 10 May 2013 03:42, Alexey Dokuchaev wrote: > On Fri, May 10, 2013 at 03:42:48AM +0000, Eitan Adler wrote: >> New Revision: 250430 >> URL: http://svnweb.freebsd.org/changeset/base/250430 >> >> @@ -79,15 +80,20 @@ main(int argc, char *argv[]) >> kvm_t *kd; >> size_t buflen, bufpos; >> long pri; >> - int all, ch; >> + int ch, clear; >> + bool all; >> >> - all = 0; >> + all = false; >> + clear = false; >> (void) setlocale(LC_CTYPE, ""); > > It's a bit weird that you've left the cast here... I didn't modify this line > > ... and here (also: notice inconsistent spacing), Or this one. >> void >> usage(void) >> { >> - (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n"); >> + fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n"); > > but removed it here for no particular reason. Notice the additional 'c' in usage(). -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams