Date: Sat, 16 Jul 2022 16:16:32 -0500 From: Mike Karels <mike@karels.net> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Mateusz Guzik <mjguzik@gmail.com>, Mike Karels <karels@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: efe58855f3ea - main - IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8 Message-ID: <7514B679-43E5-484D-8E3D-5BF3D81DFD37@karels.net> In-Reply-To: <YtMHoqLkGucZUvUt@FreeBSD.org> References: <202207131449.26DEnh0G089612@gitrepo.freebsd.org> <CAGudoHGnDCCsXqakusJNhK5E3g1Xfm%2BzUedUUF8nn3R8wp51iA@mail.gmail.com> <90326A36-85E7-49E7-944A-AED1EEC4C46B@karels.net> <YtMHoqLkGucZUvUt@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 Jul 2022, at 13:46, Gleb Smirnoff wrote: > On Sat, Jul 16, 2022 at 10:13:46AM -0500, Mike Karels wrote: > M> > This cause LINT-NOIP builds to fail: > M> > ld: error: undefined symbol: vnet_entry_in_loopback_mask > M> >>>> referenced by ib_cma.c > M> >>>> ib_cma.o:(rdma_destroy_id) > M> >>>> referenced by ib_cma.c > M> >>>> ib_cma.o:(rdma_resolve_addr) > M> >>>> referenced by ib_cma.c > M> >>>> ib_cma.o:(rdma_bind_addr) > M> >>>> referenced 11 more times > M> > M> Yuck. The Infiniband code isn=E2=80=99t ifdefed for INET (or INET6)= and just > M> uses things. One of its Linux compat shims uses IN_LOOPBACK, which = now > M> refers to a mask field via VNET. I can either add one #ifdef INET t= o > M> ib_cma.c, or remove OFED from LINT-NOIP. I suppose I should add the= > M> #ifdef; any other opinions? > > I think the right thing to do will be to add ifdefs to cma_loopback_add= r(). > > The beginning of the file should be augmented with including opt_inet.h= > and opt_inet6.h, too. Review https://reviews.freebsd.org/D35835. Mike > -- = > Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7514B679-43E5-484D-8E3D-5BF3D81DFD37>