From owner-freebsd-emulation@FreeBSD.ORG  Wed Jan 26 14:20:06 2011
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BCA89106564A;
	Wed, 26 Jan 2011 14:20:06 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3])
	by mx1.freebsd.org (Postfix) with ESMTP id 7022D8FC1C;
	Wed, 26 Jan 2011 14:20:06 +0000 (UTC)
Received: from localhost (amavis.fra.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id CB66241C6F2;
	Wed, 26 Jan 2011 15:20:05 +0100 (CET)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([192.168.74.103])
	by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id aae-Mn4ReFSq; Wed, 26 Jan 2011 15:20:05 +0100 (CET)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id 72D2741C6A7; Wed, 26 Jan 2011 15:20:05 +0100 (CET)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 309484448F3;
	Wed, 26 Jan 2011 14:18:03 +0000 (UTC)
Date: Wed, 26 Jan 2011 14:18:03 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: Mikolaj Golub <to.my.trociny@gmail.com>
In-Reply-To: <86aainkbhb.fsf@zhuzha.ua1>
Message-ID: <20110126141636.D3489@maildrop.int.zabbadoz.net>
References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org>
	<86tygwy9p0.fsf@kopusha.home.net>
	<20110126091038.C3489@maildrop.int.zabbadoz.net>
	<86aainkbhb.fsf@zhuzha.ua1>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-emulation@freebsd.org,
	FreeBSD virtualization mailing list <freebsd-virtualization@freebsd.org>
Subject: Re: VirtualBox + VIMAGE
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2011 14:20:06 -0000

On Wed, 26 Jan 2011, Mikolaj Golub wrote:

>
> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote:
>
> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version
> BAZ> checks so that the port, should it run elsewhere or on older FreeBSDs
> BAZ> (if it runs there) not trouble people having to patch it away.
>
> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500
> BAZ> #endif
>
> BAZ> might be a save bet.
>
> Thanks. Something like in the patch below?
>
> Note, I have not run this version yet. Will test it tonight or tomorrow.

Well, you will need to include <sys/param.h> as well, and that only if
you are on FreeBSD so you'll need an extra check for just that I
guess.  Not sure how vbox handles the all this in their guts.

/bz

-- 
Bjoern A. Zeeb                                 You have to have visions!
         <ks> Going to jail sucks -- <bz> All my daemons like it!
   http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html