From owner-svn-src-head@freebsd.org Fri Apr 14 15:32:43 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74EEFD3DBCD; Fri, 14 Apr 2017 15:32:43 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 14F111193; Fri, 14 Apr 2017 15:32:42 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wr0-f170.google.com with SMTP id c55so52602443wrc.3; Fri, 14 Apr 2017 08:32:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=NcItDyFqITnWjbEYmgvYUg2HtgxFjs08oe1Fib1gP8k=; b=aen8Nff4ZQIzz8Yy8jA2ZV4VMzf9zcDiObde+r9rm2yhBVhQ4gMQnSZgLJTm/i2+0X 23WqjZCldhkNyhGTwqOMCt57cAE/ADWIX6AKKUDwz2B88BoSzCiL/vdP5a3u4OIYAgtu z3bPlOec68Ai1UtDuyJ2CValsb/Rubcwuo0Xz9xnuMBcLGgCit7obdTBpvGD1igG1AlP Om7fuTtcZSe+vtGBShfYcSkIQlrfsmHAOA4T23ZPx6RW7sk9L8c4IRliv6vLoP4otoNR T73irsYuWFS1UcEGBPKfdVNq2jC7r7ZmIk7dMmqiKDLoG3aiDGEXZzbwenanEp4fY7hN BwCA== X-Gm-Message-State: AN3rC/7MPdfQUevvEQOH+tjlrfqpfu9yhnM5k+gJSqrYbEgUAZhuxy5a mdyucmCFf6c8MlMJyzkh9Q== X-Received: by 10.223.166.9 with SMTP id k9mr8049963wrc.177.1492183954925; Fri, 14 Apr 2017 08:32:34 -0700 (PDT) Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id n198sm3133528wmd.30.2017.04.14.08.32.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 08:32:34 -0700 (PDT) Received: by mail-wr0-f171.google.com with SMTP id l28so52549459wre.0; Fri, 14 Apr 2017 08:32:34 -0700 (PDT) X-Received: by 10.223.181.132 with SMTP id c4mr525428wre.178.1492183954681; Fri, 14 Apr 2017 08:32:34 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Fri, 14 Apr 2017 08:32:34 -0700 (PDT) In-Reply-To: <201704141158.v3EBwfLm003147@repo.freebsd.org> References: <201704141158.v3EBwfLm003147@repo.freebsd.org> From: Conrad Meyer Date: Fri, 14 Apr 2017 08:32:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r316826 - head/sys/netpfil/ipfw/nat64 To: "Andrey V. Elsukov" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 15:32:43 -0000 On Fri, Apr 14, 2017 at 4:58 AM, Andrey V. Elsukov wrote: > Author: ae > Date: Fri Apr 14 11:58:41 2017 > New Revision: 316826 > URL: https://svnweb.freebsd.org/changeset/base/316826 > > Log: > Avoid undefined behavior. > > The 'pktid' variable is modified while being used twice between > sequence points, probably due to htonl() is macro. FYI =E2=80=94 there are a ton of similar reports in sys/rpc due to the XDR macros (which read a network value off a pointer and increment it). See e.g., IXDR_GET_UINT32() macro. Best, Conrad