From owner-svn-src-head@freebsd.org Wed Mar 21 15:42:29 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41FBCF4EAAB for ; Wed, 21 Mar 2018 15:42:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB50876CC1 for ; Wed, 21 Mar 2018 15:42:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id l3so7189657iog.0 for ; Wed, 21 Mar 2018 08:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3MGT8ORScPruzAB3x/7OuTxH78rpZNwc7Q8SjOD65E8=; b=ARx+664c8dBNMYFb5+25CrRz0N4zEjTvKJHA6VCEx/fjuyXp5LVcETJ4VzkaXNRu8q 8xelmbcjAG6K6rnQy4OLElia4iUXXG7h7ZQrQvRKXUP2ctBgbsnHPD7NeBhCzGmoDVSI 2zUEW6Bj7WzEvtw2y+61FPv3xP91ItcM1KAno3FZK2X4S+9cqHzpcT36Jf5j8jwAv5sE 5vngD5kCFtfF2xruCpVFcJZ27uklL/fMt3VpgUF9pMVdjA+VJbq/MZZ3AaJgqgZWsHPR ssri2ASYiHy2xAmuI79krH90ItAWaNx0smPovtdx7+4ZzO5uKiOknYnGRHSCh1PVmHQC Ne+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3MGT8ORScPruzAB3x/7OuTxH78rpZNwc7Q8SjOD65E8=; b=fC+Cn7752SnuYvlB/0+ge+wlONxBtPGWyvyyYg/LyrupjE3vGxsv586loJfpPNrNBQ eoCl9swamw6YCwm2/h6PUPkhpAWyXU9GlPTLLWS4IyUeexuf1lfJdrmbvz6AD8pKsjln dU2OR6NojaAMjvc2U/rtBbXI+0YkSSCClfDIVbmcF6p6d5JpKwvFdA59oBLZ9kZFjGhh CRlbO1lyEWIdkyEoIKvmJOnbvppqHmQ+TVYvEdc+pe99F0VassB7zkgoJqnKyQBDGrrE Rt2PT7Mayq+SEJgQVt5Bjfl82doUHb41qOfbnWaRYH08uwFLcK2uMwWF4Sd+g6/3FEav 4u7w== X-Gm-Message-State: AElRT7H265ilCvYJO2Yolsiy3A2VddJ0sgTfaqJ2fM0s3eEOj0tzhZf2 feulYYFX4ALt4Wfa7BQ4E9LhbEXnjGXXjYbWA+gcMg== X-Google-Smtp-Source: AG47ELvglvGJA6p3wLJCGU+rihZu+CglY58Ts/tKxUHAc5zNIToYAgMydURhS953KgEtHvS/WBpPmSd0ELp533V1EVU= X-Received: by 10.107.12.230 with SMTP id 99mr20841542iom.117.1521646947972; Wed, 21 Mar 2018 08:42:27 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Wed, 21 Mar 2018 08:42:26 -0700 (PDT) X-Originating-IP: [50.227.106.226] In-Reply-To: References: <201803210115.w2L1Fjt9084698@repo.freebsd.org> <20180321103325.GJ76926@kib.kiev.ua> <20180321152335.GL76926@kib.kiev.ua> From: Warner Losh Date: Wed, 21 Mar 2018 09:42:26 -0600 X-Google-Sender-Auth: FxfTQR2H_fgxt1I1lKuiVTZdDGQ Message-ID: Subject: Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss To: "Conrad E. Meyer" Cc: Konstantin Belousov , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Xin LI Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 15:42:29 -0000 On Wed, Mar 21, 2018 at 9:37 AM, Conrad Meyer wrote: > On Wed, Mar 21, 2018 at 8:23 AM, Konstantin Belousov > wrote: > > On Wed, Mar 21, 2018 at 08:03:16AM -0700, Conrad Meyer wrote: > >> On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov > >> > Libraries must not abort the application. > >> > Esp. libc. > >> > >> What do you propose instead? while (1); ? I don't see that as > >> obviously better. > > > > Return the error to caller, as all, well most, correct library functions > > do. > > The abort() in case of ENOSYS was proposed by delphij@. It is > intended for users that getentropy() not fail. Another possible > fallback is to use the kern.arandom sysctl. Would this be amenable to > you? > You should get a SIGSYS unless you've setup signal handlers for ENOSYS anyway, right? Warner