From owner-freebsd-bugs@FreeBSD.ORG  Wed Jul 19 23:20:18 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 034D816A4DA
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 19 Jul 2006 23:20:18 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 78BA043D53
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 19 Jul 2006 23:20:17 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k6JNKHTh014100
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 19 Jul 2006 23:20:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k6JNKHoH014099;
	Wed, 19 Jul 2006 23:20:17 GMT (envelope-from gnats)
Resent-Date: Wed, 19 Jul 2006 23:20:17 GMT
Resent-Message-Id: <200607192320.k6JNKHoH014099@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Roberto Lima <roberto@forbrazil.com.br>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6AE8916A4E1
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 19 Jul 2006 23:19:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 391DA43D45
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 19 Jul 2006 23:19:22 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k6JNJMV3013858
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 19 Jul 2006 23:19:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k6JNJM7Y013857;
	Wed, 19 Jul 2006 23:19:22 GMT (envelope-from nobody)
Message-Id: <200607192319.k6JNJM7Y013857@www.freebsd.org>
Date: Wed, 19 Jul 2006 23:19:22 GMT
From: Roberto Lima <roberto@forbrazil.com.br>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: bin/100585: [PATCH] top -s0 causes load excessive
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jul 2006 23:20:18 -0000


>Number:         100585
>Category:       bin
>Synopsis:       [PATCH] top -s0 causes load excessive
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 19 23:20:16 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Roberto Lima
>Release:        FreeBSD 6.1
>Organization:
ForBrazil
>Environment:
FreeBSD bsd.forbr.com.br 6.1-STABLE FreeBSD 6.1-STABLE #1: Tue Jun 27 17:20:15 BRT 2006     root@bsd.forbr.com.br:/usr/src/sys/i386/compile/ForBrazil  i386

>Description:
I see that my costumers have been used 'top -s0' too many times and this is overloading in my system.
>How-To-Repeat:
just use 'top -s0' and see the load average going up.
>Fix:
--- top.c.old   Wed Jul 19 19:49:23 2006
+++ top.c       Wed Jul 19 19:49:32 2006
@@ -331,7 +331,7 @@
                break;
 
              case 's':
-               if ((delay = atoi(optarg)) < 0 || (delay == 0 && getuid() != 0))
+               if ((delay = atoi(optarg)) < 1 || (delay == 0 && getuid() != 0))
                {
                    fprintf(stderr,
                        "%s: warning: seconds delay should be positive -- using default\n",
>Release-Note:
>Audit-Trail:
>Unformatted: