From owner-freebsd-current Sun Feb 24 12:18:54 2002 Delivered-To: freebsd-current@freebsd.org Received: from mass.dis.org (dhcp45-21.dis.org [216.240.45.21]) by hub.freebsd.org (Postfix) with ESMTP id 10D8037B400 for ; Sun, 24 Feb 2002 12:18:51 -0800 (PST) Received: from mass.dis.org (localhost [127.0.0.1]) by mass.dis.org (8.11.6/8.11.6) with ESMTP id g1OKIUG00719; Sun, 24 Feb 2002 12:18:30 -0800 (PST) (envelope-from msmith@mass.dis.org) Message-Id: <200202242018.g1OKIUG00719@mass.dis.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Magnus B{ckstr|m Cc: current@freebsd.org Subject: Re: HEADS UP: ACPI CA updated In-reply-to: Your message of "Sun, 24 Feb 2002 20:14:12 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 24 Feb 2002 12:18:30 -0800 From: Michael Smith Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > Wow! This did away with the once-a-minute error messages from Notify()s > on processor objects on my laptop. > > However, I am now getting frequent panics from from a GIANT_REQUIRED > assertion in kmem_malloc(). kmem_malloc() gets called via malloc() from > AcpiOsAllocate(), without Giant locked. > > The call to AcpiOsAllocate() happens deep in a AML object evaluation > in from acpi_tz_thread(). > > I tried naively to modify AcpiOsAllocate to grab Giant before malloc() > and release it afterward, but this appears to be a very bad idea: There > is a mtx_assert(&Giant, MA_NOTOWNED) in ithread_loop() in kern/kern_intr.c > which blows up during boot. Try grabbing Giant in acpi_tz_thread when it wakes up, then dropping it again before it goes to sleep. This is probably a hack, but I'd guess a required one for now. If that works, send me a diff and I'll commit it with thanks! Regards, Mike -- To announce that there must be no criticism of the president, or that we are to stand by the president, right or wrong, is not only unpatriotic and servile, but is morally treasonable to the American public. - Theodore Roosevelt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message