Date: Tue, 16 Oct 2007 22:11:12 +0200 From: Roman Divacky <rdivacky@FreeBSD.org> To: Scott Long <scottl@samsco.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h Message-ID: <20071016201112.GA52731@freebsd.org> In-Reply-To: <471517C8.9040505@samsco.org> References: <200710122211.l9CMBM4J010733@repoman.freebsd.org> <20071016085414.GA27376@freebsd.org> <471517C8.9040505@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 16, 2007 at 01:58:00PM -0600, Scott Long wrote: > Roman Divacky wrote: > >On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote: > >>scottl 2007-10-12 22:11:22 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/cam/scsi scsi_all.h > >> Log: > >> Add a bunch of definitions and structures to support newer drivers. > > > >- page_start = (void *)((u_int8_t *)&mode_header[1] + > >+ page_start = (void *)((u_int8_t *)&mode_header[2] + > > scsi_2btoul(mode_header->blk_desc_len)); > > > >are you sure this belongs here? > > > > It's a minor bug fix that got grouped with the larger change. Are you > upset that it wasn't clearly documented in the commit message, or are > you pointing out that it's incorrect, or what? It was not documented in the commit message so I thought you might have commited something by mistake...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071016201112.GA52731>