From owner-freebsd-current  Sun Nov 17 14:46:31 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B7C6F37B404; Sun, 17 Nov 2002 14:46:28 -0800 (PST)
Received: from fatpipi.cirx.org (fatpipi.cirx.org [211.23.144.137])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BCA3043E75; Sun, 17 Nov 2002 14:46:17 -0800 (PST)
	(envelope-from clive@freebsd.org)
Received: from fatpipi.cirx.org.rose (nullmail@localhost.cirx.org [127.0.0.1])
	by fatpipi.cirx.org (8.12.6/8.12.6) with SMTP id gAHMk4pD010493;
	Mon, 18 Nov 2002 06:46:04 +0800 (CST)
	(envelope-from clive@freebsd.org)
Received: (nullmailer pid 10491 invoked by uid 1000);
	Sun, 17 Nov 2002 22:46:03 -0000
Date: Mon, 18 Nov 2002 06:46:03 +0800
From: Clive Lin <clive@freebsd.org>
To: Jake Burkholder <jake@locore.ca>
Cc: Julian Elischer <julian@elischer.org>, current@freebsd.org,
	sparc64@freebsd.org
Subject: Re: sparc64 tinderbox failure
Message-ID: <20021117224603.GA10020@fatpipi.cirx.org>
References: <200211172019.gAHKJCRT073699@bowie.private> <Pine.BSF.4.21.0211171222320.53326-100000@InterJet.elischer.org> <20021117154655.B2737@locore.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021117154655.B2737@locore.ca>
X-Operating-System: FreeBSD i386
X-PGP-key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xA008C03E
User-Agent: Mutt/1.5.1i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Sun, Nov 17, 2002 at 03:46:55PM -0500, Jake Burkholder wrote:
> Apparently, On Sun, Nov 17, 2002 at 12:23:20PM -0800,
> 	Julian Elischer said words to the effect of;
> > On Sun, 17 Nov 2002, Mike Barcroft wrote:
> > > --------------------------------------------------------------
> > > >>> Kernel build for GENERIC started on Sun Nov 17 20:01:33 GMT 2002
> > > --------------------------------------------------------------
> > > ===> ipfilter
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c: In function `kse_create':
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: `mp_ncpus' undeclared (first use in this function)
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: (Each undeclared identifier is reported only once
> > > /tinderbox/sparc64/src/sys/kern/kern_thread.c:498: for each function it appears in.)
> > 
> > 
> > ok mea culpa..
> > 
> > what is there in SPARC that should be used instead..?
> 
> mp_ncpus is defined in sys/smp.h which is not included kern_thread.c
> I don't see why this builds on any platform.
> 
> Jake

This does not compile on i386 with options SMP, either.

It looks like a '#if 0' was removed in kern_thread.c rev 1.61, which
exposes bug in SMP case.

Something like this should fix kernel building.
(I have no idea where to place the #include, though)

Index: kern_thread.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_thread.c,v
retrieving revision 1.61
diff -u -r1.61 kern_thread.c
--- kern_thread.c	17 Nov 2002 11:47:03 -0000	1.61
+++ kern_thread.c	17 Nov 2002 22:22:35 -0000
@@ -47,6 +47,10 @@
 #include <sys/ktr.h>
 #include <sys/ucontext.h>
 
+#ifdef SMP
+#include <sys/smp.h>
+#endif
+
 #include <vm/vm.h>
 #include <vm/vm_object.h>
 #include <vm/pmap.h>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message