From owner-svn-src-head@freebsd.org Sat Oct 24 00:13:30 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A183B42A21A for ; Sat, 24 Oct 2020 00:13:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CJ1ls2gWGz3Vql for ; Sat, 24 Oct 2020 00:13:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id r7so3191347qkf.3 for ; Fri, 23 Oct 2020 17:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lM6tUyN3Mx+kHaxoJGq8B0DEQO+0VTE8xXxvh3gTATA=; b=Nhcgke35u1/TzP2zj9ReU36OwqyTBE67Sv9eadVwJ7kpIsO175LAyZzM2ec4gKzXhH A75ZQF2SufiYE8OMZgnOYX4SJXZPN6NpSkVijpQoECkMujBCIpnBaZa4UBuRVaRD+7R3 XzgSYU6QsEP/KyxJ+XVMTs7+X+MR/r0hcMjl6ckyE2at/lyULug5UqTMDMbRLnCgn7W7 BMH5Z89ZoRzIuJcfF0vPcI822UvKmXbyqjzQxyKF0UDD/ZGOuAAiC6wzLmjCBgbz8DsF qtVia4rudvCOe0OyqOq00oB7duBmNh/EZW1ufN8BG5UND6CaIkjplhwDrtZjRG0FepQp S3jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lM6tUyN3Mx+kHaxoJGq8B0DEQO+0VTE8xXxvh3gTATA=; b=RvWu0PMdZbLCPHa0DxDBmWPNnUTdKPxFCFDdDGwh8jxyWFSASA+5Epi2mvHDcumLrQ HVXw9TGbjpnq4T2jdwbJc1/mwlpKvFdkbE2TcGVUHJp0vKKoQK4PJfBHxh+tyWlnLCLU m6f4Et/ahqV6wlb2qyu+iN4iPmFesJdXAT9+T+VQi7ltcq2lxPxw8OLEQxyRV9XUxtj7 vCELCOiNEetTEYOy6QO4wpSn3JPLvn+iDJavqfJWh83Gi0gGISPMD+rbBIXc2/rbaaMb EOoS57OfpuNgezFlnra7yNg9KDTN/P76DoHkIj2RkwpTKLDULRkTnglqTr0SfvbcVX2b 1TJw== X-Gm-Message-State: AOAM530KS0TLqV0eOY7DTjcUMBMp6jeAJqBUFoP1XBJMurMja7DPk/Zj 7JyUdX9FA/WuTWywEOMjXWsfkDzREATjfZNpcEwX8A== X-Google-Smtp-Source: ABdhPJxetQP4RukmlrkxbDokpi28VbIbRn35ylpb5nP1GkLJORzm3BMgbWOYtfDFXF/yoEyuJvS8r3tOm2SPKOomA3k= X-Received: by 2002:a37:5ca:: with SMTP id 193mr5039696qkf.44.1603498408391; Fri, 23 Oct 2020 17:13:28 -0700 (PDT) MIME-Version: 1.0 References: <202010021826.092IQfdj023808@repo.freebsd.org> <44421602932538@mail.yandex.ru> <43251602934532@mail.yandex.ru> <59021602950992@mail.yandex.ru> In-Reply-To: From: Warner Losh Date: Fri, 23 Oct 2020 18:13:17 -0600 Message-ID: Subject: Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf To: Kyle Evans Cc: Niclas Zeising , "Alexander V. Chernikov" , Hans Petter Selasky , Emmanuel Vadot , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 4CJ1ls2gWGz3Vql X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Nhcgke35; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::732) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.98 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.990]; NEURAL_HAM_LONG(-0.96)[-0.964]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.02)[-1.024]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::732:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-head]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 00:13:30 -0000 I was going to suggest and try this change, but life has been complicated... Has it been committed? Warner On Thu, Oct 22, 2020, 1:43 PM Kyle Evans wrote: > On Thu, Oct 22, 2020 at 2:35 PM Niclas Zeising > wrote: > > > > On 2020-10-22 15:22, Kyle Evans wrote: > > > On Sat, Oct 17, 2020 at 11:40 AM Warner Losh wrote: > > >> > > >> > > >> > > >> On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov < > melifaro@ipfw.ru> wrote: > > >>> > > >>> 17.10.2020, 14:07, "Hans Petter Selasky" : > > >>> > > >>> On 2020-10-17 14:34, Alexander V. Chernikov wrote: > > >>> > > >>> 17.10.2020, 12:32, "Hans Petter Selasky" : > > >>> > > >>> On 2020-10-17 13:27, Alexander V. Chernikov wrote: > > >>> > > >>> 02.10.2020, 19:26, "Emmanuel Vadot" > >>> >: > > >>> > > >>> Author: manu > > >>> Date: Fri Oct 2 18:26:41 2020 > > >>> New Revision: 366372 > > >>> URL: > https://svnweb.freebsd.org/changeset/base/366372 > > >>> > > >>> Log: > > >>> linuxkpi: Add backlight support > > >>> > > >>> Add backlight function to linuxkpi. > > >>> Graphics drivers expose the backlight of the > panel directly so > > >>> allow them > > >>> to use the backlight subsystem so > > >>> user can use backlight(8) to configure them. > > >>> > > >>> Reviewed by: hselasky > > >>> Relnotes: yes > > >>> Differential Revision: The FreeBSD Foundation > > >>> > > >>> Added: > > >>> > head/sys/compat/linuxkpi/common/include/linux/backlight.h > > >>> (contents, > > >>> props changed) > > >>> Modified: > > >>> > head/sys/compat/linuxkpi/common/include/linux/device.h > > >>> head/sys/compat/linuxkpi/common/src/linux_kmod.c > > >>> head/sys/compat/linuxkpi/common/src/linux_pci.c > > >>> head/sys/conf/kmod.mk > > >>> > > >>> It breaks the build for me with > > >>> > /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10: > > >>> fatal error: 'backlight_if.h' file not found > > >>> > > >>> > > >>> How do you build? Doesn't break over here. > > >>> > > >>> GENERIC + COMPAT_LINUXKPI. > > >>> > > >>> > > >>> > > >>> Try adding: > > >>> > > >>> options backlight > > >>> > > >>> To the kernel config. > > >>> > > >>> Yep, thank you! > > >>> Maybe it's worth considering adding static assert with the message > describing this dependency? > > >> > > >> > > >> Yes. It likely is worth doing something to highlight this issue. > > >> > > >> Warner > > >> > > > > > > I think we just need to slap the two core backlight files with an ` | > > > compat_linux` so that they simply get pulled in if you specify > > > COMPAT_LINUX. config(8) handles this terribly, configng must have a > > > better provides/requires/implies/whatever functionality so we can > > > specify that compat_linux implies backlight and not do crud like this > > > where it becomes more complicated to see what any given option really > > > entails. > > > > > > Thanks, > > > > COMPAT_LINUX can't be right. Isn't that the linuxolator? > > Regards > > -- > > Niclas Zeising > > Whoops, s/LINUX/LINUXKPI/ > > :-) >