From owner-p4-projects@FreeBSD.ORG Wed May 9 19:43:48 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C44F116A408; Wed, 9 May 2007 19:43:47 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9EEEE16A404; Wed, 9 May 2007 19:43:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 44DA713C44C; Wed, 9 May 2007 19:43:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l49JhbDQ094093; Wed, 9 May 2007 15:43:37 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Attilio Rao" Date: Wed, 9 May 2007 15:43:32 -0400 User-Agent: KMail/1.9.6 References: <200705062110.l46LAZqE011583@repoman.freebsd.org> <200705091457.39167.jhb@freebsd.org> <3bbf2fe10705091233t405121d2qda9a058ecf4124bc@mail.gmail.com> In-Reply-To: <3bbf2fe10705091233t405121d2qda9a058ecf4124bc@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705091543.33002.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 09 May 2007 15:43:37 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3224/Wed May 9 11:25:29 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Perforce Change Reviews , Rui Paulo Subject: Re: PERFORCE change 119371 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 19:43:48 -0000 On Wednesday 09 May 2007 03:33:11 pm Attilio Rao wrote: > 2007/5/9, John Baldwin : > > On Sunday 06 May 2007 05:10:35 pm Rui Paulo wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=119371 > > > > > > Change 119371 by rpaulo@rpaulo_epsilon on 2007/05/06 21:10:15 > > > > > > We don't need any scheduler support because: > > > 1) msrtemp is a child of cpu - this implies that every > > > rdmsr/cpuid instruction will be executed on that CPU. > > > > No, that isn't true. You do need to use sched_bind() for that so you are > > really on the desired CPU when you read the MSR. > > I think he just needs msr of the cpu where curthread is executed, so > any scheduler lock should be needed. > If he needs to know msr of a particular CPU he really needs so, but it > doesn't seem the case. The sysctl is per-CPU, so he needs the msr from a specific CPU in the sysctl handler. I.e., it's like dev.cpu.0.temp or some such. -- John Baldwin